Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 2383403002: Reflow comments in core/loader (Closed)
Patch Set: yhirano comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org) 2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)
3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 #include "platform/text/TextCheckerClient.h" 46 #include "platform/text/TextCheckerClient.h"
47 #include "public/platform/WebFocusType.h" 47 #include "public/platform/WebFocusType.h"
48 #include "public/platform/WebFrameScheduler.h" 48 #include "public/platform/WebFrameScheduler.h"
49 #include "public/platform/WebScreenInfo.h" 49 #include "public/platform/WebScreenInfo.h"
50 #include "wtf/Forward.h" 50 #include "wtf/Forward.h"
51 #include <memory> 51 #include <memory>
52 #include <v8.h> 52 #include <v8.h>
53 53
54 /* 54 /*
55 This file holds empty Client stubs for use by WebCore. 55 This file holds empty Client stubs for use by WebCore.
56 Viewless element needs to create a dummy Page->LocalFrame->FrameView tree for u se in parsing or executing JavaScript.
57 This tree depends heavily on Clients (usually provided by WebKit classes).
58 56
59 This file was first created for SVGImage as it had no way to access the current Page (nor should it, 57 Viewless element needs to create a dummy Page->LocalFrame->FrameView tree for
60 since Images are not tied to a page). 58 use in parsing or executing JavaScript. This tree depends heavily on Clients
61 See http://bugs.webkit.org/show_bug.cgi?id=5971 for the original discussion abo ut this file. 59 (usually provided by WebKit classes).
60
61 This file was first created for SVGImage as it had no way to access the current
62 Page (nor should it, since Images are not tied to a page). See
63 http://bugs.webkit.org/show_bug.cgi?id=5971 for the original discussion about
64 this file.
62 65
63 Ideally, whenever you change a Client class, you should add a stub here. 66 Ideally, whenever you change a Client class, you should add a stub here.
64 Brittle, yes. Unfortunate, yes. Hopefully temporary. 67 Brittle, yes. Unfortunate, yes. Hopefully temporary.
65 */ 68 */
66 69
67 namespace blink { 70 namespace blink {
68 71
69 class CORE_EXPORT EmptyChromeClient : public ChromeClient { 72 class CORE_EXPORT EmptyChromeClient : public ChromeClient {
70 public: 73 public:
71 static EmptyChromeClient* create() { return new EmptyChromeClient; } 74 static EmptyChromeClient* create() { return new EmptyChromeClient; }
72 75
73 ~EmptyChromeClient() override {} 76 ~EmptyChromeClient() override {}
74 void chromeDestroyed() override {} 77 void chromeDestroyed() override {}
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 ~EmptyContextMenuClient() override {} 428 ~EmptyContextMenuClient() override {}
426 bool showContextMenu(const ContextMenu*, bool) override { return false; } 429 bool showContextMenu(const ContextMenu*, bool) override { return false; }
427 void clearContextMenu() override {} 430 void clearContextMenu() override {}
428 }; 431 };
429 432
430 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&); 433 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);
431 434
432 } // namespace blink 435 } // namespace blink
433 436
434 #endif // EmptyClients_h 437 #endif // EmptyClients_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698