third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp - Issue 2383403002: Reflow comments in core/loader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

Issue 2383403002: Reflow comments in core/loader (Closed)

Patch Set: yhirano comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h ('k') | third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

diff --git a/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp b/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

index 1c290a4ba9c3e2965cb85c29879b1fdf859de69f..277b8a50949e2d9d26063e79e5b6e1ca11613a4b 100644

--- a/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

+++ b/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

@@ -36,9 +36,12 @@

namespace blink {

// These values are at the discretion of the user agent.

static const unsigned defaultPreflightCacheTimeoutSeconds = 5;

-static const unsigned maxPreflightCacheTimeoutSeconds =

- 600; // Should be short enough to minimize the risk of using a poisoned cache after switching to a secure network.

+// Should be short enough to minimize the risk of using a poisoned cache after

+// switching to a secure network.

+static const unsigned maxPreflightCacheTimeoutSeconds = 600;

static bool parseAccessControlMaxAge(const String& string,

unsigned& expiryDelta) {