Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp

Issue 2383403002: Reflow comments in core/loader (Closed)
Patch Set: yhirano comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "core/fetch/FetchUtils.h" 29 #include "core/fetch/FetchUtils.h"
30 #include "platform/HTTPNames.h" 30 #include "platform/HTTPNames.h"
31 #include "platform/network/ResourceResponse.h" 31 #include "platform/network/ResourceResponse.h"
32 #include "wtf/CurrentTime.h" 32 #include "wtf/CurrentTime.h"
33 #include "wtf/StdLibExtras.h" 33 #include "wtf/StdLibExtras.h"
34 #include <memory> 34 #include <memory>
35 35
36 namespace blink { 36 namespace blink {
37 37
38 // These values are at the discretion of the user agent. 38 // These values are at the discretion of the user agent.
39
39 static const unsigned defaultPreflightCacheTimeoutSeconds = 5; 40 static const unsigned defaultPreflightCacheTimeoutSeconds = 5;
40 static const unsigned maxPreflightCacheTimeoutSeconds = 41
41 600; // Should be short enough to minimize the risk of using a poisoned cac he after switching to a secure network. 42 // Should be short enough to minimize the risk of using a poisoned cache after
43 // switching to a secure network.
44 static const unsigned maxPreflightCacheTimeoutSeconds = 600;
42 45
43 static bool parseAccessControlMaxAge(const String& string, 46 static bool parseAccessControlMaxAge(const String& string,
44 unsigned& expiryDelta) { 47 unsigned& expiryDelta) {
45 // FIXME: this will not do the correct thing for a number starting with a '+' 48 // FIXME: this will not do the correct thing for a number starting with a '+'
46 bool ok = false; 49 bool ok = false;
47 expiryDelta = string.toUIntStrict(&ok); 50 expiryDelta = string.toUIntStrict(&ok);
48 return ok; 51 return ok;
49 } 52 }
50 53
51 template <class HashType> 54 template <class HashType>
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 return false; 201 return false;
199 202
200 if (cacheIt->value->allowsRequest(includeCredentials, method, requestHeaders)) 203 if (cacheIt->value->allowsRequest(includeCredentials, method, requestHeaders))
201 return true; 204 return true;
202 205
203 m_preflightHashMap.remove(cacheIt); 206 m_preflightHashMap.remove(cacheIt);
204 return false; 207 return false;
205 } 208 }
206 209
207 } // namespace blink 210 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698