Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 23822003: Have EditCommand classes deal with Document references, not pointers (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
tkent, dglazkov
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Have EditCommand classes deal with Document references, not pointers Have EditCommand classes deal with Document references, not pointers, as it can never be NULL. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -332 lines) Patch
M Source/core/editing/AppendNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 14 chunks +21 lines, -21 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 22 chunks +36 lines, -36 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/EditCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/EditCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.cpp View 18 chunks +52 lines, -26 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 11 chunks +28 lines, -14 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/InsertListCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M Source/core/editing/InsertTextCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ModifySelectionListLevel.h View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/ModifySelectionListLevel.cpp View 5 chunks +16 lines, -18 lines 0 comments Download
M Source/core/editing/MoveSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveFormatCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveFormatCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveNodePreservingChildrenCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 15 chunks +16 lines, -16 lines 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SetSelectionCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellingCorrectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/SplitTextNodeContainingElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 12 chunks +23 lines, -34 lines 0 comments Download
M Source/core/editing/UnlinkCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/UnlinkCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-02 13:20:32 UTC) #1
dglazkov
rslgtm.
7 years, 3 months ago (2013-09-02 15:13:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23822003/1
7 years, 3 months ago (2013-09-02 15:15:24 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 15:36:47 UTC) #4
Message was sent while issue was closed.
Change committed as 157085

Powered by Google App Engine
This is Rietveld 408576698