Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: Source/core/editing/SetSelectionCommand.cpp

Issue 23822003: Have EditCommand classes deal with Document references, not pointers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 14 matching lines...) Expand all
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/editing/SetSelectionCommand.h" 27 #include "core/editing/SetSelectionCommand.h"
28 28
29 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
30 #include "core/page/Frame.h" 30 #include "core/page/Frame.h"
31 31
32 namespace WebCore { 32 namespace WebCore {
33 33
34 SetSelectionCommand::SetSelectionCommand(const VisibleSelection& selection, Fram eSelection::SetSelectionOptions options) 34 SetSelectionCommand::SetSelectionCommand(const VisibleSelection& selection, Fram eSelection::SetSelectionOptions options)
35 : SimpleEditCommand(&selection.base().anchorNode()->document()) 35 : SimpleEditCommand(selection.base().anchorNode()->document())
36 , m_options(options) 36 , m_options(options)
37 , m_selectionToSet(selection) 37 , m_selectionToSet(selection)
38 { 38 {
39 } 39 }
40 40
41 void SetSelectionCommand::doApply() 41 void SetSelectionCommand::doApply()
42 { 42 {
43 FrameSelection* selection = document()->frame()->selection(); 43 FrameSelection* selection = document().frame()->selection();
44 ASSERT(selection); 44 ASSERT(selection);
45 45
46 if (selection->shouldChangeSelection(m_selectionToSet) && m_selectionToSet.i sNonOrphanedCaretOrRange()) { 46 if (selection->shouldChangeSelection(m_selectionToSet) && m_selectionToSet.i sNonOrphanedCaretOrRange()) {
47 selection->setSelection(m_selectionToSet, m_options); 47 selection->setSelection(m_selectionToSet, m_options);
48 setEndingSelection(m_selectionToSet); 48 setEndingSelection(m_selectionToSet);
49 } 49 }
50 } 50 }
51 51
52 void SetSelectionCommand::doUnapply() 52 void SetSelectionCommand::doUnapply()
53 { 53 {
54 FrameSelection* selection = document()->frame()->selection(); 54 FrameSelection* selection = document().frame()->selection();
55 ASSERT(selection); 55 ASSERT(selection);
56 56
57 if (selection->shouldChangeSelection(startingSelection()) && startingSelecti on().isNonOrphanedCaretOrRange()) 57 if (selection->shouldChangeSelection(startingSelection()) && startingSelecti on().isNonOrphanedCaretOrRange())
58 selection->setSelection(startingSelection(), m_options); 58 selection->setSelection(startingSelection(), m_options);
59 } 59 }
60 60
61 } // namespace WebCore 61 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/editing/SetNodeAttributeCommand.cpp ('k') | Source/core/editing/SimplifyMarkupCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698