Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: Source/core/editing/EditCommand.cpp

Issue 23822003: Have EditCommand classes deal with Document references, not pointers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/EditCommand.h ('k') | Source/core/editing/Editor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2007 Apple, Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2007 Apple, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 #include "core/editing/EditCommand.h" 27 #include "core/editing/EditCommand.h"
28 28
29 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
30 #include "core/dom/NodeTraversal.h" 30 #include "core/dom/NodeTraversal.h"
31 #include "core/editing/CompositeEditCommand.h" 31 #include "core/editing/CompositeEditCommand.h"
32 #include "core/editing/FrameSelection.h" 32 #include "core/editing/FrameSelection.h"
33 #include "core/page/Frame.h" 33 #include "core/page/Frame.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 EditCommand::EditCommand(Document* document) 37 EditCommand::EditCommand(Document& document)
38 : m_document(document) 38 : m_document(&document)
39 , m_parent(0) 39 , m_parent(0)
40 { 40 {
41 ASSERT(m_document); 41 ASSERT(m_document);
42 ASSERT(m_document->frame()); 42 ASSERT(m_document->frame());
43 setStartingSelection(m_document->frame()->selection()->selection()); 43 setStartingSelection(m_document->frame()->selection()->selection());
44 setEndingSelection(m_startingSelection); 44 setEndingSelection(m_startingSelection);
45 } 45 }
46 46
47 EditCommand::EditCommand(Document* document, const VisibleSelection& startingSel ection, const VisibleSelection& endingSelection) 47 EditCommand::EditCommand(Document* document, const VisibleSelection& startingSel ection, const VisibleSelection& endingSelection)
48 : m_document(document) 48 : m_document(document)
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 112
113 #ifndef NDEBUG 113 #ifndef NDEBUG
114 void SimpleEditCommand::addNodeAndDescendants(Node* startNode, HashSet<Node*>& n odes) 114 void SimpleEditCommand::addNodeAndDescendants(Node* startNode, HashSet<Node*>& n odes)
115 { 115 {
116 for (Node* node = startNode; node; node = NodeTraversal::next(node, startNod e)) 116 for (Node* node = startNode; node; node = NodeTraversal::next(node, startNod e))
117 nodes.add(node); 117 nodes.add(node);
118 } 118 }
119 #endif 119 #endif
120 120
121 } // namespace WebCore 121 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/editing/EditCommand.h ('k') | Source/core/editing/Editor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698