Have EditCommand classes deal with Document references, not pointers

Source/core/editing/ModifySelectionListLevel.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 17 matching lines @@
 
 #include "core/dom/Document.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/htmlediting.h"
 #include "core/html/HTMLElement.h"
 #include "core/page/Frame.h"
 #include "core/rendering/RenderObject.h"
 
 namespace WebCore {
 
-ModifySelectionListLevelCommand::ModifySelectionListLevelCommand(Document* document)
+ModifySelectionListLevelCommand::ModifySelectionListLevelCommand(Document& document)
     : CompositeEditCommand(document)
 {
 }
 
 bool ModifySelectionListLevelCommand::preservesTypingStyle() const
 {
     return true;
 }
 
 // This needs to be static so it can be called by canIncreaseSelectionListLevel and canDecreaseSelectionListLevel
@@ skipping 78 matching lines @@
         removeNode(node);
         appendNode(node, newParent);
 
         if (node == endNode)
             break;
 
         node = next;
     }
 }
 
-IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand(Document* document, Type listType)
+IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand(Document& document, Type listType)
     : ModifySelectionListLevelCommand(document)
     , m_listType(listType)
 {
 }
 
 // This needs to be static so it can be called by canIncreaseSelectionListLevel
 static bool canIncreaseListLevel(const VisibleSelection& selection, Node*& start, Node*& end)
 {
     if (!getStartEndListChildren(selection, start, end))
         return false;
@@ skipping 35 matching lines @@
     } else {
         // create a sublist for the preceding element and move nodes there
         RefPtr<Element> newParent;
         switch (m_listType) {
             case InheritedListType:
                 newParent = startListChild->parentElement();
                 if (newParent)
                     newParent = newParent->cloneElementWithoutChildren();
                 break;
             case OrderedList:
-                newParent = createOrderedListElement(document());
+                newParent = createOrderedListElement(&document());
                 break;
             case UnorderedList:
-                newParent = createUnorderedListElement(document());
+                newParent = createUnorderedListElement(&document());
                 break;
         }
         insertNodeBefore(newParent, startListChild);
         appendSiblingNodeRange(startListChild, endListChild, newParent.get());
         m_listElement = newParent.release();
     }
 }
 
-bool IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel(Document* document)
+bool IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel(Document& document)
 {
     Node* startListChild;
     Node* endListChild;
-    return canIncreaseListLevel(document->frame()->selection()->selection(), startListChild, endListChild);
+    return canIncreaseListLevel(document.frame()->selection()->selection(), startListChild, endListChild);
 }
 
-PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document* document, Type type)
+PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document& document, Type type)
 {
-    ASSERT(document);
-    ASSERT(document->frame());
+    ASSERT(document.frame());
     RefPtr<IncreaseSelectionListLevelCommand> command = create(document, type);
     command->apply();
     return command->m_listElement.release();
 }
 
-PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document* document)
+PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document& document)
 {
     return increaseSelectionListLevel(document, InheritedListType);
 }
 
-PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered(Document* document)
+PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered(Document& document)
 {
     return increaseSelectionListLevel(document, OrderedList);
 }
 
-PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered(Document* document)
+PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered(Document& document)
 {
     return increaseSelectionListLevel(document, UnorderedList);
 }
 
-DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand(Document* document)
+DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand(Document& document)
     : ModifySelectionListLevelCommand(document)
 {
 }
 
 // This needs to be static so it can be called by canDecreaseSelectionListLevel
 static bool canDecreaseListLevel(const VisibleSelection& selection, Node*& start, Node*& end)
 {
     if (!getStartEndListChildren(selection, start, end))
         return false;
 
@@ skipping 24 matching lines @@
     } else if (!nextItem) {
         // at end of list, move the child(ren) to after the sublist
         insertSiblingNodeRangeAfter(startListChild, endListChild, listNode);
     } else if (listNode) {
         // in the middle of list, split the list and move the children to the divide
         splitElement(listNode, startListChild);
         insertSiblingNodeRangeBefore(startListChild, endListChild, listNode);
     }
 }
 
-bool DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel(Document* document)
+bool DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel(Document& document)
 {
     Node* startListChild;
     Node* endListChild;
-    return canDecreaseListLevel(document->frame()->selection()->selection(), startListChild, endListChild);
+    return canDecreaseListLevel(document.frame()->selection()->selection(), startListChild, endListChild);
 }
 
-void DecreaseSelectionListLevelCommand::decreaseSelectionListLevel(Document* document)
+void DecreaseSelectionListLevelCommand::decreaseSelectionListLevel(Document& document)
 {
-    ASSERT(document);
-    ASSERT(document->frame());
+    ASSERT(document.frame());
     applyCommand(create(document));
 }
 
 }