Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/core/editing/InsertIntoTextNodeCommand.cpp

Issue 23822003: Have EditCommand classes deal with Document references, not pointers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 17 matching lines...) Expand all
28 28
29 #include "bindings/v8/ExceptionStatePlaceholder.h" 29 #include "bindings/v8/ExceptionStatePlaceholder.h"
30 #include "core/dom/Document.h" 30 #include "core/dom/Document.h"
31 #include "core/dom/Text.h" 31 #include "core/dom/Text.h"
32 #include "core/page/Settings.h" 32 #include "core/page/Settings.h"
33 #include "core/rendering/RenderText.h" 33 #include "core/rendering/RenderText.h"
34 34
35 namespace WebCore { 35 namespace WebCore {
36 36
37 InsertIntoTextNodeCommand::InsertIntoTextNodeCommand(PassRefPtr<Text> node, unsi gned offset, const String& text) 37 InsertIntoTextNodeCommand::InsertIntoTextNodeCommand(PassRefPtr<Text> node, unsi gned offset, const String& text)
38 : SimpleEditCommand(&node->document()) 38 : SimpleEditCommand(node->document())
39 , m_node(node) 39 , m_node(node)
40 , m_offset(offset) 40 , m_offset(offset)
41 , m_text(text) 41 , m_text(text)
42 { 42 {
43 ASSERT(m_node); 43 ASSERT(m_node);
44 ASSERT(m_offset <= m_node->length()); 44 ASSERT(m_offset <= m_node->length());
45 ASSERT(!m_text.isEmpty()); 45 ASSERT(!m_text.isEmpty());
46 } 46 }
47 47
48 void InsertIntoTextNodeCommand::doApply() 48 void InsertIntoTextNodeCommand::doApply()
49 { 49 {
50 bool passwordEchoEnabled = document()->settings() && document()->settings()- >passwordEchoEnabled(); 50 bool passwordEchoEnabled = document().settings() && document().settings()->p asswordEchoEnabled();
51 if (passwordEchoEnabled) 51 if (passwordEchoEnabled)
52 document()->updateLayoutIgnorePendingStylesheets(); 52 document().updateLayoutIgnorePendingStylesheets();
53 53
54 if (!m_node->rendererIsEditable()) 54 if (!m_node->rendererIsEditable())
55 return; 55 return;
56 56
57 if (passwordEchoEnabled) { 57 if (passwordEchoEnabled) {
58 RenderText* renderText = toRenderText(m_node->renderer()); 58 RenderText* renderText = toRenderText(m_node->renderer());
59 if (renderText && renderText->isSecure()) 59 if (renderText && renderText->isSecure())
60 renderText->momentarilyRevealLastTypedCharacter(m_offset + m_text.le ngth() - 1); 60 renderText->momentarilyRevealLastTypedCharacter(m_offset + m_text.le ngth() - 1);
61 } 61 }
62 62
63 m_node->insertData(m_offset, m_text, IGNORE_EXCEPTION, DeprecatedAttachNow); 63 m_node->insertData(m_offset, m_text, IGNORE_EXCEPTION, DeprecatedAttachNow);
64 } 64 }
65 65
66 void InsertIntoTextNodeCommand::doUnapply() 66 void InsertIntoTextNodeCommand::doUnapply()
67 { 67 {
68 if (!m_node->rendererIsEditable()) 68 if (!m_node->rendererIsEditable())
69 return; 69 return;
70 70
71 m_node->deleteData(m_offset, m_text.length(), IGNORE_EXCEPTION, DeprecatedAt tachNow); 71 m_node->deleteData(m_offset, m_text.length(), IGNORE_EXCEPTION, DeprecatedAt tachNow);
72 } 72 }
73 73
74 #ifndef NDEBUG 74 #ifndef NDEBUG
75 void InsertIntoTextNodeCommand::getNodesInCommand(HashSet<Node*>& nodes) 75 void InsertIntoTextNodeCommand::getNodesInCommand(HashSet<Node*>& nodes)
76 { 76 {
77 addNodeAndDescendants(m_node.get(), nodes); 77 addNodeAndDescendants(m_node.get(), nodes);
78 } 78 }
79 #endif 79 #endif
80 80
81 } // namespace WebCore 81 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/editing/InputMethodController.cpp ('k') | Source/core/editing/InsertLineBreakCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698