Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs. (Closed)

Created:
4 years, 2 months ago by Jeffrey Yasskin
Modified:
4 years, 2 months ago
Reviewers:
ortuno, dcheng
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, haraken, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw a TypeError instead of a SyntaxError on invalid UUIDs. Matches https://github.com/WebBluetoothCG/web-bluetooth/pull/298. Committed: https://crrev.com/e60fb41d64bbbd96e201bb6e26e6774846ab0a80 Cr-Commit-Position: refs/heads/master@{#421745}

Patch Set 1 #

Messages

Total messages: 19 (10 generated)
Jeffrey Yasskin
4 years, 2 months ago (2016-09-28 20:19:49 UTC) #2
ortuno
lgtm
4 years, 2 months ago (2016-09-28 23:19:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380843002/1
4 years, 2 months ago (2016-09-28 23:21:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/269060)
4 years, 2 months ago (2016-09-28 23:29:26 UTC) #11
Jeffrey Yasskin
Daniel, could you lgtm the comment removal in web_bluetooth.mojom?
4 years, 2 months ago (2016-09-28 23:32:41 UTC) #13
dcheng
lgtm
4 years, 2 months ago (2016-09-29 01:10:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380843002/1
4 years, 2 months ago (2016-09-29 04:29:50 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 04:34:30 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 04:36:04 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e60fb41d64bbbd96e201bb6e26e6774846ab0a80
Cr-Commit-Position: refs/heads/master@{#421745}

Powered by Google App Engine
This is Rietveld 408576698