| OLD | NEW |
|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <script src="../../resources/testharness.js"></script> | 2 <script src="../../resources/testharness.js"></script> |
| 3 <script src="../../resources/testharnessreport.js"></script> | 3 <script src="../../resources/testharnessreport.js"></script> |
| 4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script> | 4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script> |
| 5 <script> | 5 <script> |
| 6 'use strict'; | 6 'use strict'; |
| 7 promise_test(() => { | 7 promise_test(() => { |
| 8 return setBluetoothFakeAdapter('HeartRateAdapter') | 8 return setBluetoothFakeAdapter('HeartRateAdapter') |
| 9 .then(() => requestDeviceWithKeyDown({ | 9 .then(() => requestDeviceWithKeyDown({ |
| 10 filters: [{services: ['heart_rate']}], | 10 filters: [{services: ['heart_rate']}], |
| 11 optionalServices: ['generic_access']})) | 11 optionalServices: ['generic_access']})) |
| 12 .then(device => device.gatt.connect()) | 12 .then(device => device.gatt.connect()) |
| 13 .then(gattServer => gattServer.getPrimaryService('generic_access')) | 13 .then(gattServer => gattServer.getPrimaryService('generic_access')) |
| 14 .then(service => { | 14 .then(service => { |
| 15 return assert_promise_rejects_with_message( | 15 return assert_promise_rejects_with_message( |
| 16 service.getCharacteristics('wrong_name'), new DOMException( | 16 service.getCharacteristics('wrong_name'), new DOMException( |
| 17 'Failed to execute \'getCharacteristics\' on ' + | 17 'Failed to execute \'getCharacteristics\' on ' + |
| 18 '\'BluetoothRemoteGATTService\': Invalid Characteristic name: ' + | 18 '\'BluetoothRemoteGATTService\': Invalid Characteristic name: ' + |
| 19 '\'wrong_name\'. ' + | 19 '\'wrong_name\'. ' + |
| 20 'It must be a valid UUID alias (e.g. 0x1234), ' + | 20 'It must be a valid UUID alias (e.g. 0x1234), ' + |
| 21 'UUID (lowercase hex characters e.g. ' + | 21 'UUID (lowercase hex characters e.g. ' + |
| 22 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' + | 22 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' + |
| 23 'or recognized standard name from ' + | 23 'or recognized standard name from ' + |
| 24 'https://developer.bluetooth.org/gatt/characteristics/' + | 24 'https://developer.bluetooth.org/gatt/characteristics/' + |
| 25 'Pages/CharacteristicsHome.aspx' + | 25 'Pages/CharacteristicsHome.aspx' + |
| 26 ' e.g. \'aerobic_heart_rate_lower_limit\'.', | 26 ' e.g. \'aerobic_heart_rate_lower_limit\'.', |
| 27 'SyntaxError'), | 27 'TypeError'), |
| 28 'Wrong Characteristic name passed.'); | 28 'Wrong Characteristic name passed.'); |
| 29 }); | 29 }); |
| 30 }, 'Invalid Characteristic name. Reject with SyntaxError.'); | 30 }, 'Invalid Characteristic name. Reject with TypeError.'); |
| 31 </script> | 31 </script> |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2380843002:
Throw a TypeError instead of a SyntaxError on invalid UUIDs. (Closed)
