third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/invalid-service-name.html - Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/invalid-service-name.html

Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/invalid-characteristic-name.html ('k') | third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/invalid-service-name.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

11 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

12 .then(gattServer => {	12 .then(gattServer => {

13 return assert_promise_rejects_with_message(	13 return assert_promise_rejects_with_message(

14 gattServer.getPrimaryService('wrong_name'), new DOMException(	14 gattServer.getPrimaryService('wrong_name'), new DOMException(

15 'Failed to execute \'getPrimaryService\' on ' +	15 'Failed to execute \'getPrimaryService\' on ' +

16 '\'BluetoothRemoteGATTServer\': Invalid Service name: ' +	16 '\'BluetoothRemoteGATTServer\': Invalid Service name: ' +

17 '\'wrong_name\'. ' +	17 '\'wrong_name\'. ' +

18 'It must be a valid UUID alias (e.g. 0x1234), ' +	18 'It must be a valid UUID alias (e.g. 0x1234), ' +

19 'UUID (lowercase hex characters e.g. ' +	19 'UUID (lowercase hex characters e.g. ' +

20 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +	20 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +

21 'or recognized standard name from ' +	21 'or recognized standard name from ' +

22 'https://developer.bluetooth.org/gatt/services/Pages/ServicesHome.aspx ' +	22 'https://developer.bluetooth.org/gatt/services/Pages/ServicesHome.aspx ' +

23 ' e.g. \'alert_notification\'.',	23 ' e.g. \'alert_notification\'.',

24 'SyntaxError'),	24 'TypeError'),

25 'Wrong Service name passed.');	25 'Wrong Service name passed.');

26 });	26 });

27 }, 'Wrong Service name. Reject with SyntaxError.');	27 }, 'Wrong Service name. Reject with TypeError.');

28 </script>	28 </script>

OLD	NEW