Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/getPrimaryService/invalid-service-name.html

Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../../resources/testharness.js"></script> 2 <script src="../../resources/testharness.js"></script>
3 <script src="../../resources/testharnessreport.js"></script> 3 <script src="../../resources/testharnessreport.js"></script>
4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script> 4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>
5 <script> 5 <script>
6 'use strict'; 6 'use strict';
7 promise_test(() => { 7 promise_test(() => {
8 return setBluetoothFakeAdapter('HeartRateAdapter') 8 return setBluetoothFakeAdapter('HeartRateAdapter')
9 .then(() => requestDeviceWithKeyDown({ 9 .then(() => requestDeviceWithKeyDown({
10 filters: [{services: ['heart_rate']}]})) 10 filters: [{services: ['heart_rate']}]}))
11 .then(device => device.gatt.connect()) 11 .then(device => device.gatt.connect())
12 .then(gattServer => { 12 .then(gattServer => {
13 return assert_promise_rejects_with_message( 13 return assert_promise_rejects_with_message(
14 gattServer.getPrimaryService('wrong_name'), new DOMException( 14 gattServer.getPrimaryService('wrong_name'), new DOMException(
15 'Failed to execute \'getPrimaryService\' on ' + 15 'Failed to execute \'getPrimaryService\' on ' +
16 '\'BluetoothRemoteGATTServer\': Invalid Service name: ' + 16 '\'BluetoothRemoteGATTServer\': Invalid Service name: ' +
17 '\'wrong_name\'. ' + 17 '\'wrong_name\'. ' +
18 'It must be a valid UUID alias (e.g. 0x1234), ' + 18 'It must be a valid UUID alias (e.g. 0x1234), ' +
19 'UUID (lowercase hex characters e.g. ' + 19 'UUID (lowercase hex characters e.g. ' +
20 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' + 20 '\'00001234-0000-1000-8000-00805f9b34fb\'), ' +
21 'or recognized standard name from ' + 21 'or recognized standard name from ' +
22 'https://developer.bluetooth.org/gatt/services/Pages/ServicesHome.aspx ' + 22 'https://developer.bluetooth.org/gatt/services/Pages/ServicesHome.aspx ' +
23 ' e.g. \'alert_notification\'.', 23 ' e.g. \'alert_notification\'.',
24 'SyntaxError'), 24 'TypeError'),
25 'Wrong Service name passed.'); 25 'Wrong Service name passed.');
26 }); 26 });
27 }, 'Wrong Service name. Reject with SyntaxError.'); 27 }, 'Wrong Service name. Reject with TypeError.');
28 </script> 28 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698