third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp - Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

Issue 2380843002: Throw a TypeError instead of a SyntaxError on invalid UUIDs. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

index 77b1ac583398ad021cc2339548c713e38de9691b..7a8a3ac17b38ace94eab356f2f40448ba27b30bf 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp

@@ -327,8 +327,8 @@ String getUUIDForGATTAttribute(GATTAttribute attribute, StringOrUnsignedLong nam

" e.g. 'gatt.characteristic_presentation_format'.");

break;

}

- // Otherwise, throw a SyntaxError.

- exceptionState.throwDOMException(SyntaxError, errorMessage.toString());

+ // Otherwise, throw a TypeError.

+ exceptionState.throwDOMException(V8TypeError, errorMessage.toString());

return String();

}