Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 237873003: Rename wm_core_export.h to wm_export.h and the wm_core target to just wm (Closed)

Created:
6 years, 8 months ago by Ben Goodger (Google)
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : recipes #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -170 lines) Patch
M ash/ash.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/base_focus_rules.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/capture_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/compound_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/easy_resize_window_targeter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/focus_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/wm/core/focus_rules.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/image_grid.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/input_method_event_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/masked_window_targeter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/native_cursor_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/native_cursor_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/shadow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/shadow_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/shadow_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/transient_window_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_stacking_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/user_activity_detector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/user_activity_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/visibility_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/wm/core/window_animations.h View 4 chunks +13 lines, -15 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/window_modality_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/wm/core/window_util.h View 3 chunks +15 lines, -17 lines 0 comments Download
D ui/wm/core/wm_core_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/wm/core/wm_core_switches.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/wm_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/wm.gyp View 1 5 chunks +6 lines, -17 lines 0 comments Download
A ui/wm/wm_export.h View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ben Goodger (Google)
I ran into issues with the other, larger CL so I am breaking this one ...
6 years, 8 months ago (2014-04-14 22:42:54 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 8 months ago (2014-04-15 03:05:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/237873003/20001
6 years, 8 months ago (2014-04-15 03:06:35 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 03:58:41 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61451
6 years, 8 months ago (2014-04-15 03:58:42 UTC) #5
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 8 months ago (2014-04-15 05:20:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/237873003/20001
6 years, 8 months ago (2014-04-15 05:21:19 UTC) #7
commit-bot: I haz the power
Change committed as 263812
6 years, 8 months ago (2014-04-15 11:14:15 UTC) #8
ppi
A revert of this CL has been created in https://codereview.chromium.org/239023002/ by ppi@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-15 12:15:50 UTC) #9
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 8 months ago (2014-04-15 17:40:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/237873003/60001
6 years, 8 months ago (2014-04-15 17:41:34 UTC) #11
Ben Goodger (Google)
6 years, 8 months ago (2014-04-15 21:05:25 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 manually as r263994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698