Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2377853002: Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)

Created:
4 years, 2 months ago by sky
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged() Also gets mus side working too. BUG=650755 TEST=none R=jamescook@chromium.org Committed: https://crrev.com/3fdae2f73beeb79c2b1f2c964e3fd290c4bb3e6c Cr-Commit-Position: refs/heads/master@{#421633}

Patch Set 1 #

Patch Set 2 : order #

Total comments: 9

Patch Set 3 : feedback #

Total comments: 4

Patch Set 4 : EXPECT_FALSE #

Patch Set 5 : parent and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -1 line) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/test/ash_test.h View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M ash/common/test/ash_test.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M ash/common/wm_window_observer.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A ash/common/wm_window_unittest.cc View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
sky
4 years, 2 months ago (2016-09-28 00:18:10 UTC) #1
James Cook
https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h File ash/common/test/ash_test.h (right): https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h#newcode69 ash/common/test/ash_test.h:69: // Creates a visible window parented to |parent| with ...
4 years, 2 months ago (2016-09-28 01:19:58 UTC) #2
sky
https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h File ash/common/test/ash_test.h (right): https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h#newcode69 ash/common/test/ash_test.h:69: // Creates a visible window parented to |parent| with ...
4 years, 2 months ago (2016-09-28 18:16:37 UTC) #3
James Cook
LGTM. Thanks for adding the extra test. https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h File ash/common/test/ash_test.h (right): https://codereview.chromium.org/2377853002/diff/20001/ash/common/test/ash_test.h#newcode69 ash/common/test/ash_test.h:69: // Creates ...
4 years, 2 months ago (2016-09-28 19:02:49 UTC) #4
sky
https://codereview.chromium.org/2377853002/diff/40001/ash/common/wm_window_unittest.cc File ash/common/wm_window_unittest.cc (right): https://codereview.chromium.org/2377853002/diff/40001/ash/common/wm_window_unittest.cc#newcode65 ash/common/wm_window_unittest.cc:65: EXPECT_EQ(false, observer.last_observed_visible_value()); On 2016/09/28 19:02:49, James Cook wrote: > ...
4 years, 2 months ago (2016-09-28 19:30:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377853002/70001
4 years, 2 months ago (2016-09-28 19:30:34 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 2 months ago (2016-09-28 20:44:48 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:47:08 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3fdae2f73beeb79c2b1f2c964e3fd290c4bb3e6c
Cr-Commit-Position: refs/heads/master@{#421633}

Powered by Google App Engine
This is Rietveld 408576698