Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged()

ash/common/test/ash_test.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_TEST_ASH_TEST_H_
 #define ASH_COMMON_TEST_ASH_TEST_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 48 matching lines @@
 
   // Creates a top level visible window in the appropriate container. If
   // |bounds_is_screen| is empty the window is added to the primary root window,
   // otherwise the window is added to the display matching |bounds_in_screen|.
   // |shell_window_id| is the shell window id to give to the new window.
   std::unique_ptr<WindowOwner> CreateTestWindow(
       const gfx::Rect& bounds_in_screen = gfx::Rect(),
       ui::wm::WindowType type = ui::wm::WINDOW_TYPE_NORMAL,
       int shell_window_id = kShellWindowId_Invalid);
 
+  // Creates a visible window parented to |parent| with the specified bounds and

[James Cook, 2016/09/28 01:19:58]

nit: document that it creates and shows. (I've been burned many times in my own
code by forgetting to show windows. :-)

[sky, 2016/09/28 18:16:36]

Doesn't the visible imply shows?

[James Cook, 2016/09/28 19:02:49]

I guess, but I missed that. Up to you.

+  // id.
+  std::unique_ptr<WindowOwner> CreateChildWindow(
+      WmWindow* parent,
+      const gfx::Rect& bounds = gfx::Rect(),
+      int shell_window_id = kShellWindowId_Invalid);
+
   // Returns the Display for the secondary display. It's assumed there is two
   // displays.
   display::Display GetSecondaryDisplay();
 
   // Sets the placement of the secondary display. Returns true if the secondary
   // display can be moved, false otherwise. The false return value is temporary
   // until mus fully supports this.
   bool SetSecondaryDisplayPlacement(
       display::DisplayPlacement::Position position,
       int offset);
@@ skipping 11 matching lines @@
 
  private:
   std::unique_ptr<AshTestImpl> test_impl_;
 
   DISALLOW_COPY_AND_ASSIGN(AshTest);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_TEST_ASH_TEST_H_