Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: ash/mus/bridge/wm_window_mus.cc

Issue 2377853002: Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)
Patch Set: parent and merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/mus/bridge/wm_window_mus.h" 5 #include "ash/mus/bridge/wm_window_mus.h"
6 6
7 #include "ash/common/wm/container_finder.h" 7 #include "ash/common/wm/container_finder.h"
8 #include "ash/common/wm/window_positioning_utils.h" 8 #include "ash/common/wm/window_positioning_utils.h"
9 #include "ash/common/wm/window_state.h" 9 #include "ash/common/wm/window_state.h"
10 #include "ash/common/wm_layout_manager.h" 10 #include "ash/common/wm_layout_manager.h"
(...skipping 904 matching lines...) Expand 10 before | Expand all | Expand 10 after
915 } 915 }
916 916
917 void WmWindowMus::OnWindowDestroying(ui::Window* window) { 917 void WmWindowMus::OnWindowDestroying(ui::Window* window) {
918 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this)); 918 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this));
919 } 919 }
920 920
921 void WmWindowMus::OnWindowDestroyed(ui::Window* window) { 921 void WmWindowMus::OnWindowDestroyed(ui::Window* window) {
922 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this)); 922 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this));
923 } 923 }
924 924
925 void WmWindowMus::OnWindowVisibilityChanging(ui::Window* window) {
926 DCHECK_EQ(window_, window);
927 FOR_EACH_OBSERVER(WmWindowObserver, observers_,
928 OnWindowVisibilityChanging(this, !window->visible()));
929 }
930
931 void WmWindowMus::OnWindowVisibilityChanged(ui::Window* window) {
932 FOR_EACH_OBSERVER(WmWindowObserver, observers_,
933 OnWindowVisibilityChanged(Get(window), window->visible()));
934 }
935
925 void WmWindowMus::OnTransientChildAdded(ui::Window* window, 936 void WmWindowMus::OnTransientChildAdded(ui::Window* window,
926 ui::Window* transient) { 937 ui::Window* transient) {
927 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_, 938 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
928 OnTransientChildAdded(this, Get(transient))); 939 OnTransientChildAdded(this, Get(transient)));
929 } 940 }
930 941
931 void WmWindowMus::OnTransientChildRemoved(ui::Window* window, 942 void WmWindowMus::OnTransientChildRemoved(ui::Window* window,
932 ui::Window* transient) { 943 ui::Window* transient) {
933 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_, 944 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
934 OnTransientChildRemoved(this, Get(transient))); 945 OnTransientChildRemoved(this, Get(transient)));
935 } 946 }
936 947
937 } // namespace mus 948 } // namespace mus
938 } // namespace ash 949 } // namespace ash
OLDNEW
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698