Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: ash/common/wm_window_observer.h

Issue 2377853002: Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)
Patch Set: parent and merge Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm_window_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_WINDOW_OBSERVER_H_ 5 #ifndef ASH_COMMON_WM_WINDOW_OBSERVER_H_
6 #define ASH_COMMON_WM_WINDOW_OBSERVER_H_ 6 #define ASH_COMMON_WM_WINDOW_OBSERVER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "ash/ash_export.h" 10 #include "ash/ash_export.h"
(...skipping 28 matching lines...) Expand all
39 virtual void OnWindowStackingChanged(WmWindow* window) {} 39 virtual void OnWindowStackingChanged(WmWindow* window) {}
40 40
41 virtual void OnWindowDestroying(WmWindow* window) {} 41 virtual void OnWindowDestroying(WmWindow* window) {}
42 virtual void OnWindowDestroyed(WmWindow* window) {} 42 virtual void OnWindowDestroyed(WmWindow* window) {}
43 43
44 virtual void OnWindowBoundsChanged(WmWindow* window, 44 virtual void OnWindowBoundsChanged(WmWindow* window,
45 const gfx::Rect& old_bounds, 45 const gfx::Rect& old_bounds,
46 const gfx::Rect& new_bounds) {} 46 const gfx::Rect& new_bounds) {}
47 47
48 virtual void OnWindowVisibilityChanging(WmWindow* window, bool visible) {} 48 virtual void OnWindowVisibilityChanging(WmWindow* window, bool visible) {}
49
50 // Behavior of this function matches that of
51 // aura::WindowObserver::OnWindowVisibilityChanged(), see it for details.
49 virtual void OnWindowVisibilityChanged(WmWindow* window, bool visible) {} 52 virtual void OnWindowVisibilityChanged(WmWindow* window, bool visible) {}
50 53
51 virtual void OnWindowTitleChanged(WmWindow* window) {} 54 virtual void OnWindowTitleChanged(WmWindow* window) {}
52 55
53 protected: 56 protected:
54 virtual ~WmWindowObserver() {} 57 virtual ~WmWindowObserver() {}
55 }; 58 };
56 59
57 } // namespace ash 60 } // namespace ash
58 61
59 #endif // ASH_COMMON_WM_WINDOW_OBSERVER_H_ 62 #endif // ASH_COMMON_WM_WINDOW_OBSERVER_H_
OLDNEW
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm_window_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698