Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: ash/common/wm_window_observer.h

Issue 2377853002: Test coverage for bug in WmWindowAura::OnWindowVisibilityChanged() (Closed)
Patch Set: parent and merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm_window_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm_window_observer.h
diff --git a/ash/common/wm_window_observer.h b/ash/common/wm_window_observer.h
index a50b00e74e13336b8c2f8426dcc7e29d22c2a4c1..544fa3bc3c517f9f89a0c4562843a706597bdc44 100644
--- a/ash/common/wm_window_observer.h
+++ b/ash/common/wm_window_observer.h
@@ -46,6 +46,9 @@ class ASH_EXPORT WmWindowObserver {
const gfx::Rect& new_bounds) {}
virtual void OnWindowVisibilityChanging(WmWindow* window, bool visible) {}
+
+ // Behavior of this function matches that of
+ // aura::WindowObserver::OnWindowVisibilityChanged(), see it for details.
virtual void OnWindowVisibilityChanged(WmWindow* window, bool visible) {}
virtual void OnWindowTitleChanged(WmWindow* window) {}
« no previous file with comments | « ash/common/test/ash_test.cc ('k') | ash/common/wm_window_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698