Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2377223002: CC Animations: Rewrite unit tests to work with AnimationPlayer. (Closed)

Created:
4 years, 2 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animations: Rewrite unit tests to work with AnimationPlayer. We add/remove/etc animations to AnimationPlayer now. ElementAnimations is a light helper class. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/bb50779edb1c0c7a08c5873c9d246c9a30687703 Cr-Commit-Position: refs/heads/master@{#422714}

Patch Set 1 #

Patch Set 2 : Reparent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1240 lines, -1464 lines) Patch
M cc/animation/animation_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/animation_player.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/animation/element_animations.h View 1 6 chunks +4 lines, -22 lines 0 comments Download
M cc/animation/element_animations.cc View 1 3 chunks +12 lines, -74 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 130 chunks +1082 lines, -1172 lines 0 comments Download
M cc/animation/scroll_offset_animations_impl.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/test/animation_test_common.h View 1 4 chunks +9 lines, -31 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 12 chunks +33 lines, -55 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 2 chunks +4 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 4 chunks +5 lines, -15 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 19 chunks +76 lines, -62 lines 0 comments Download
M cc/trees/mutator_host_client.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (15 generated)
loyso (OOO)
4 years, 2 months ago (2016-09-29 06:24:55 UTC) #6
ajuma
lgtm
4 years, 2 months ago (2016-09-29 18:25:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377223002/20001
4 years, 2 months ago (2016-10-04 05:25:56 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 05:31:20 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 05:33:02 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb50779edb1c0c7a08c5873c9d246c9a30687703
Cr-Commit-Position: refs/heads/master@{#422714}

Powered by Google App Engine
This is Rietveld 408576698