Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2363733004: UI Compositor Animation: Remove cc::ElementAnimations state storage. (Closed)

Created:
4 years, 2 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
Reviewers:
Ian Vollick, ajuma
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UI Compositor Animation: Remove cc::ElementAnimations state storage. We don't need to preserve the state of cc::ElementAnimations between detach/attach. All state lives in cc::AnimationPlayer now. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/cc8e3dbd19a6f1747cb4df0d8913c9dceb5c56d6 Cr-Commit-Position: refs/heads/master@{#422711}

Patch Set 1 #

Patch Set 2 : Reparent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -64 lines) Patch
M cc/animation/animation_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/animation/animation_host.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M ui/compositor/layer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/compositor/layer_animator.h View 2 chunks +2 lines, -7 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 chunk +3 lines, -32 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
loyso (OOO)
vollick@, ui/compositor/layer.cc please, ajuma@, animations (the rest) please!
4 years, 2 months ago (2016-09-23 05:56:12 UTC) #9
ajuma
lgtm
4 years, 2 months ago (2016-09-23 13:41:36 UTC) #10
loyso (OOO)
vollick@, ping? Just one file with a few renamings.
4 years, 2 months ago (2016-09-27 05:32:06 UTC) #11
Ian Vollick
On 2016/09/27 05:32:06, loyso wrote: > vollick@, ping? Just one file with a few renamings. ...
4 years, 2 months ago (2016-09-27 10:30:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363733004/20001
4 years, 2 months ago (2016-10-04 05:17:28 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 05:22:27 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 05:24:41 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc8e3dbd19a6f1747cb4df0d8913c9dceb5c56d6
Cr-Commit-Position: refs/heads/master@{#422711}

Powered by Google App Engine
This is Rietveld 408576698