Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. A lazy deopt via a return needs to preserve one value (the result), but via a throw needs to preserve two values (the exception and stacktrace). Fixes #27446. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/e1a252a017a3588b8b9ad58f854a1622a8372f6d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -94 lines) Patch
M runtime/vm/clustered_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +20 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 5 chunks +47 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 5 chunks +48 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 6 chunks +44 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 5 chunks +46 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 7 chunks +47 lines, -9 lines 0 comments Download
A + tests/language/vm/lazy_deopt_with_exception_and_stacktrace_test.dart View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 2 months ago (2016-09-28 23:27:39 UTC) #3
Florian Schneider
LGTM
4 years, 2 months ago (2016-09-28 23:36:43 UTC) #4
rmacnak
4 years, 2 months ago (2016-09-28 23:51:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e1a252a017a3588b8b9ad58f854a1622a8372f6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698