Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 1120
1121 EndCodeSourceRange(TokenPosition::kDartCodePrologue); 1121 EndCodeSourceRange(TokenPosition::kDartCodePrologue);
1122 VisitBlocks(); 1122 VisitBlocks();
1123 1123
1124 __ bkpt(0); 1124 __ bkpt(0);
1125 ASSERT(assembler()->constant_pool_allowed()); 1125 ASSERT(assembler()->constant_pool_allowed());
1126 GenerateDeferredCode(); 1126 GenerateDeferredCode();
1127 1127
1128 BeginCodeSourceRange(); 1128 BeginCodeSourceRange();
1129 if (is_optimizing() && !FLAG_precompiled_mode) { 1129 if (is_optimizing() && !FLAG_precompiled_mode) {
1130 // Leave enough space for patching in case of lazy deoptimization from 1130 // Leave enough space for patching in case of lazy deoptimization.
1131 // deferred code.
1132 for (intptr_t i = 0; 1131 for (intptr_t i = 0;
1133 i < CallPattern::DeoptCallPatternLengthInInstructions(); 1132 i < CallPattern::DeoptCallPatternLengthInInstructions();
1134 ++i) { 1133 ++i) {
1135 __ nop(); 1134 __ nop();
1136 } 1135 }
1137 lazy_deopt_pc_offset_ = assembler()->CodeSize(); 1136 lazy_deopt_return_pc_offset_ = assembler()->CodeSize();
1138 __ Branch(*StubCode::DeoptimizeLazy_entry()); 1137 __ Branch(*StubCode::DeoptimizeLazyFromReturn_entry());
1138 lazy_deopt_throw_pc_offset_ = assembler()->CodeSize();
1139 __ Branch(*StubCode::DeoptimizeLazyFromThrow_entry());
1139 } 1140 }
1140 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue); 1141 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue);
1141 } 1142 }
1142 1143
1143 1144
1144 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos, 1145 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
1145 const StubEntry& stub_entry, 1146 const StubEntry& stub_entry,
1146 RawPcDescriptors::Kind kind, 1147 RawPcDescriptors::Kind kind,
1147 LocationSummary* locs) { 1148 LocationSummary* locs) {
1148 __ BranchLinkPatchable(stub_entry); 1149 __ BranchLinkPatchable(stub_entry);
(...skipping 847 matching lines...) Expand 10 before | Expand all | Expand 10 after
1996 DRegister dreg = EvenDRegisterOf(reg); 1997 DRegister dreg = EvenDRegisterOf(reg);
1997 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1998 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1998 } 1999 }
1999 2000
2000 2001
2001 #undef __ 2002 #undef __
2002 2003
2003 } // namespace dart 2004 } // namespace dart
2004 2005
2005 #endif // defined TARGET_ARCH_ARM 2006 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698