runtime/vm/deopt_instructions.cc - Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/deopt_instructions.cc

Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/deopt_instructions.cc

diff --git a/runtime/vm/deopt_instructions.cc b/runtime/vm/deopt_instructions.cc

index e658740f4cae75447090f79a13e20eaf7061bb9c..18aa1a181cfd579a6d56da5c27cca27090a9a832 100644

--- a/runtime/vm/deopt_instructions.cc

+++ b/runtime/vm/deopt_instructions.cc

@@ -697,7 +697,7 @@ class DeoptPcMarkerInstr : public DeoptInstr {

function ^= deopt_context->ObjectAt(object_table_index_);

if (function.IsNull()) {

*reinterpret_cast<RawObject**>(dest_addr) = deopt_context->is_lazy_deopt()

- ? StubCode::DeoptimizeLazy_entry()->code()

+ ? StubCode::DeoptimizeLazyFromReturn_entry()->code()

: StubCode::Deoptimize_entry()->code();

return;

}

« no previous file with comments | « runtime/vm/code_generator.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »