Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Side by Side Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1123 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 } 1134 }
1135 1135
1136 EndCodeSourceRange(TokenPosition::kDartCodePrologue); 1136 EndCodeSourceRange(TokenPosition::kDartCodePrologue);
1137 VisitBlocks(); 1137 VisitBlocks();
1138 1138
1139 __ break_(0); 1139 __ break_(0);
1140 GenerateDeferredCode(); 1140 GenerateDeferredCode();
1141 1141
1142 BeginCodeSourceRange(); 1142 BeginCodeSourceRange();
1143 if (is_optimizing() && !FLAG_precompiled_mode) { 1143 if (is_optimizing() && !FLAG_precompiled_mode) {
1144 // Leave enough space for patching in case of lazy deoptimization from 1144 // Leave enough space for patching in case of lazy deoptimization.
1145 // deferred code.
1146 for (intptr_t i = 0; 1145 for (intptr_t i = 0;
1147 i < CallPattern::kDeoptCallLengthInInstructions; 1146 i < CallPattern::kDeoptCallLengthInInstructions;
1148 ++i) { 1147 ++i) {
1149 __ nop(); 1148 __ nop();
1150 } 1149 }
1151 lazy_deopt_pc_offset_ = assembler()->CodeSize(); 1150 lazy_deopt_return_pc_offset_ = assembler()->CodeSize();
1152 __ Branch(*StubCode::DeoptimizeLazy_entry()); 1151 __ Branch(*StubCode::DeoptimizeLazyFromReturn_entry());
1152 lazy_deopt_throw_pc_offset_ = assembler()->CodeSize();
1153 __ Branch(*StubCode::DeoptimizeLazyFromThrow_entry());
1153 } 1154 }
1154 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue); 1155 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue);
1155 } 1156 }
1156 1157
1157 1158
1158 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos, 1159 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
1159 const StubEntry& stub_entry, 1160 const StubEntry& stub_entry,
1160 RawPcDescriptors::Kind kind, 1161 RawPcDescriptors::Kind kind,
1161 LocationSummary* locs) { 1162 LocationSummary* locs) {
1162 __ BranchLinkPatchable(stub_entry); 1163 __ BranchLinkPatchable(stub_entry);
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
1957 __ AddImmediate(SP, kDoubleSize); 1958 __ AddImmediate(SP, kDoubleSize);
1958 } 1959 }
1959 1960
1960 1961
1961 #undef __ 1962 #undef __
1962 1963
1963 1964
1964 } // namespace dart 1965 } // namespace dart
1965 1966
1966 #endif // defined TARGET_ARCH_MIPS 1967 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698