Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 2374273002: Fix a throw returning to a frame marked for lazy deopt that captures the stacktrace. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 1131
1132 EndCodeSourceRange(TokenPosition::kDartCodePrologue); 1132 EndCodeSourceRange(TokenPosition::kDartCodePrologue);
1133 ASSERT(!block_order().is_empty()); 1133 ASSERT(!block_order().is_empty());
1134 VisitBlocks(); 1134 VisitBlocks();
1135 1135
1136 __ int3(); 1136 __ int3();
1137 GenerateDeferredCode(); 1137 GenerateDeferredCode();
1138 1138
1139 BeginCodeSourceRange(); 1139 BeginCodeSourceRange();
1140 if (is_optimizing() && !FLAG_precompiled_mode) { 1140 if (is_optimizing() && !FLAG_precompiled_mode) {
1141 // Leave enough space for patching in case of lazy deoptimization from 1141 // Leave enough space for patching in case of lazy deoptimization.
1142 // deferred code.
1143 __ nop(CallPattern::pattern_length_in_bytes()); 1142 __ nop(CallPattern::pattern_length_in_bytes());
1144 lazy_deopt_pc_offset_ = assembler()->CodeSize(); 1143 lazy_deopt_return_pc_offset_ = assembler()->CodeSize();
1145 __ Jmp(*StubCode::DeoptimizeLazy_entry()); 1144 __ Jmp(*StubCode::DeoptimizeLazyFromReturn_entry());
1145 lazy_deopt_throw_pc_offset_ = assembler()->CodeSize();
1146 __ Jmp(*StubCode::DeoptimizeLazyFromThrow_entry());
1146 } 1147 }
1147 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue); 1148 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue);
1148 } 1149 }
1149 1150
1150 1151
1151 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos, 1152 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
1152 const StubEntry& stub_entry, 1153 const StubEntry& stub_entry,
1153 RawPcDescriptors::Kind kind, 1154 RawPcDescriptors::Kind kind,
1154 LocationSummary* locs) { 1155 LocationSummary* locs) {
1155 __ Call(stub_entry); 1156 __ Call(stub_entry);
(...skipping 706 matching lines...) Expand 10 before | Expand all | Expand 10 after
1862 __ movups(reg, Address(ESP, 0)); 1863 __ movups(reg, Address(ESP, 0));
1863 __ addl(ESP, Immediate(kFpuRegisterSize)); 1864 __ addl(ESP, Immediate(kFpuRegisterSize));
1864 } 1865 }
1865 1866
1866 1867
1867 #undef __ 1868 #undef __
1868 1869
1869 } // namespace dart 1870 } // namespace dart
1870 1871
1871 #endif // defined TARGET_ARCH_IA32 1872 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698