Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength.

Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file
to the cpp file for tidiness.

BUG=545318
Committed: https://crrev.com/490d8b83c0e77b041c3eaafa69600553f22d44ca
Cr-Commit-Position: refs/heads/master@{#421771}

[meade_UTC10, 2016-09-28 04:54:01]

Description was changed from

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

This is laying some groundwork for CSSValue -> CSSCalcLength.

BUG=545318
==========

to

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file 
to the cpp file for tidiness.

BUG=545318
==========

[meade_UTC10, 2016-09-28 04:54:13]

meade@chromium.org changed reviewers:
+ rjwright@chromium.org

[meade_UTC10, 2016-09-28 04:54:39]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 04:54:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 06:02:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 06:02:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rjwright, 2016-09-29 05:34:43]

LGTM

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp (right):

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp:7: #include
"bindings/core/v8/ExceptionState.h"
Do we need this?

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp (right):

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp:7: #include
"core/css/CSSCalculationValue.h"
I don't think any of these extra includes are needed for this CL.

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp:25:
CSSStyleValue* styleValueForPrimitiveValue(CSSPropertyID propertyID, const
CSSPrimitiveValue& primitiveValue)
propertyID isn't used

[meade_UTC10, 2016-09-29 05:53:13]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-09-29 05:53:14]

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp (right):

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp:7: #include
"bindings/core/v8/ExceptionState.h"
On 2016/09/29 05:34:42, rjwright wrote:
> Do we need this?

Yep, it was previously included transitively through CSSSimpleLength.h, but I
removed it from there, so now it's needed here.

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp (right):

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp:7: #include
"core/css/CSSCalculationValue.h"
On 2016/09/29 05:34:42, rjwright wrote:
> I don't think any of these extra includes are needed for this CL.

Done.

https://codereview.chromium.org/2373233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp:25:
CSSStyleValue* styleValueForPrimitiveValue(CSSPropertyID propertyID, const
CSSPrimitiveValue& primitiveValue)
On 2016/09/29 05:34:42, rjwright wrote:
> propertyID isn't used

Done.

[meade_UTC10, 2016-09-29 05:53:24]

+Tim for owners

[meade_UTC10, 2016-09-29 05:53:30]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 05:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 07:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 07:16:47]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-09-29 07:34:35]

On 2016/09/29 05:53:24, Eddy wrote:
> +Tim for owners

lgtm

[meade_UTC10, 2016-09-29 07:38:20]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-09-29 07:38:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org
Link to the patchset: https://codereview.chromium.org/2373233002/#ps40001
(title: "Update test expectations, remove extra includes and unused args")

[commit-bot: I haz the power, 2016-09-29 07:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 07:44:30]

Description was changed from

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file 
to the cpp file for tidiness.

BUG=545318
==========

to

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file 
to the cpp file for tidiness.

BUG=545318
==========

[commit-bot: I haz the power, 2016-09-29 07:44:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-29 07:46:51]

Description was changed from

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file 
to the cpp file for tidiness.

BUG=545318
==========

to

==========
Add fromCSSValue methods to LengthValue subclasses, remove extra method in
CSSSimpleLength.

Does not implement CSSCalcLength::fromCSSValue yet, as that will
follow up in a larger change.

Also moved some methods in CSSSimpleLength from the header file
to the cpp file for tidiness.

BUG=545318

Committed: https://crrev.com/490d8b83c0e77b041c3eaafa69600553f22d44ca
Cr-Commit-Position: refs/heads/master@{#421771}
==========

[commit-bot: I haz the power, 2016-09-29 07:46:52]

Patchset 3 (id:??) landed as
https://crrev.com/490d8b83c0e77b041c3eaafa69600553f22d44ca
Cr-Commit-Position: refs/heads/master@{#421771}