Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp

Issue 2373233002: Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength. (Closed)
Patch Set: Update test expectations, remove extra includes and unused args Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp
index 878ed5be782d8eafcc60a19b7860cd0610b84958..b2455c63847872d053ecfa7a4bde5f78fa420f6e 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp
@@ -4,6 +4,7 @@
#include "core/css/cssom/CSSCalcLength.h"
+#include "bindings/core/v8/ExceptionState.h"
#include "core/css/CSSCalculationValue.h"
#include "core/css/CSSPrimitiveValue.h"
#include "core/css/cssom/CSSCalcDictionary.h"
@@ -68,6 +69,12 @@ CSSCalcLength* CSSCalcLength::create(const CSSCalcDictionary& dictionary, Except
return result;
}
+CSSCalcLength* CSSCalcLength::fromCSSValue(const CSSPrimitiveValue&)
+{
+ // TODO(meade): Implement.
+ return nullptr;
+}
+
bool CSSCalcLength::containsPercent() const
{
return has(CSSPrimitiveValue::UnitType::Percentage);
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h ('k') | third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698