Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength.

third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/CSSCalcLength.h"
 
+#include "bindings/core/v8/ExceptionState.h"

[rjwright, 2016/09/29 05:34:42]

Do we need this?

[meade_UTC10, 2016/09/29 05:53:13]

Yep, it was previously included transitively through CSSSimpleLength.h, but I
removed it from there, so now it's needed here.

 #include "core/css/CSSCalculationValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/cssom/CSSCalcDictionary.h"
 #include "core/css/cssom/CSSSimpleLength.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 CSSCalcLength::CSSCalcLength() : m_values(CSSLengthValue::kNumSupportedUnits), m_hasValues(CSSLengthValue::kNumSupportedUnits) {}
 
@@ skipping 44 matching lines @@
     setFromDictValue(in, In, Inches)
     setFromDictValue(pc, Pc, Picas)
     setFromDictValue(pt, Pt, Points)
 
     if (numSet == 0) {
         exceptionState.throwTypeError("Must specify at least one value in CSSCalcDictionary for creating a CSSCalcLength.");
     }
     return result;
 }
 
+CSSCalcLength* CSSCalcLength::fromCSSValue(const CSSPrimitiveValue&)
+{
+    // TODO(meade): Implement.
+    return nullptr;
+}
+
 bool CSSCalcLength::containsPercent() const
 {
     return has(CSSPrimitiveValue::UnitType::Percentage);
 }
 
 CSSLengthValue* CSSCalcLength::addInternal(const CSSLengthValue* other)
 {
     CSSCalcLength* result = CSSCalcLength::create(other);
     for (int i = 0; i < CSSLengthValue::kNumSupportedUnits; ++i) {
         if (hasAtIndex(i)) {
@@ skipping 62 matching lines @@
     }
     return CSSPrimitiveValue::create(CSSCalcValue::create(node));
 }
 
 int CSSCalcLength::indexForUnit(CSSPrimitiveValue::UnitType unit)
 {
     return (static_cast<int>(unit) - static_cast<int>(CSSPrimitiveValue::UnitType::Percentage));
 }
 
 } // namespace blink