Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2380933002: Update generated CSSOM type checking to allow checking just the type (Closed)

Created:
4 years, 2 months ago by meade_UTC10
Modified:
4 years, 2 months ago
Reviewers:
dstockwell, rjwright, rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update generated CSSOM type checking to allow checking just the type This is in addition to being able to check a whole CSSStyleValue. BUG=545318 Committed: https://crrev.com/6c8b54d9ddc32e7c5537fc6ca49080567ee7306e Cr-Commit-Position: refs/heads/master@{#422062}

Patch Set 1 #

Patch Set 2 : Unparent branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSOMTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
meade_UTC10
This is a pretty simple CL. PTAL.
4 years, 2 months ago (2016-09-29 06:11:00 UTC) #4
rune
lgtm
4 years, 2 months ago (2016-09-29 09:33:18 UTC) #7
rune
lgtm lgtm
4 years, 2 months ago (2016-09-29 09:33:19 UTC) #8
rune
On 2016/09/29 09:33:19, rune wrote: > lgtm > > lgtm Uhm. That was weird.
4 years, 2 months ago (2016-09-29 09:34:08 UTC) #9
meade_UTC10
On 2016/09/29 09:34:08, rune wrote: > On 2016/09/29 09:33:19, rune wrote: > > lgtm > ...
4 years, 2 months ago (2016-09-30 06:24:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380933002/20001
4 years, 2 months ago (2016-09-30 06:24:03 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 08:11:26 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:13:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c8b54d9ddc32e7c5537fc6ca49080567ee7306e
Cr-Commit-Position: refs/heads/master@{#422062}

Powered by Google App Engine
This is Rietveld 408576698