third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h - Issue 2373233002: Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

Issue 2373233002: Add fromCSSValue methods to LengthValue subclasses, remove extra method in CSSSimpleLength. (Closed)

Patch Set: Update test expectations, remove extra includes and unused args Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

index 0fdac8391ae45a11e5e3ec7443c7f80f6e909da9..8681572982b2277bdf54fd0d7bb0761d9a1f1be4 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

+++ b/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h

@@ -22,6 +22,7 @@ public:

{

return create(length);

}

+ static CSSCalcLength* fromCSSValue(const CSSPrimitiveValue&);

#define GETTER_MACRO(name, type) \

double name(bool& isNull) \