Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100
Committed: https://crrev.com/a0b3fb78ec4871dca5673c8650baeb96324d1faf
Cr-Commit-Position: refs/heads/master@{#421339}

[scottmg, 2016-09-26 22:28:04]

Description was changed from

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

BUG=crashpad:100
==========

to

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-26 22:28:05]

scottmg@chromium.org changed reviewers:
+ asvitkine@chromium.org

[scottmg, 2016-09-26 22:28:27]

Please take a look for histograms.xml. Thanks!

[Alexei Svitkine (slow), 2016-09-27 15:48:48]

lgtm % comments

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7461: +  <summary>Counts of crash upload
successes and failures.</summary>
Nit: Instead of "counts" which suggests you're logging values like 7, I would
phrase it as "Logs whether a crash upload succeeded or failed."

The plural counts is implicit in the aggregation.

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:75067: +  <int value="0"
label="kNewlyCreated"/>
Nit: Suggest using human readable strings here - e.g. "Newly created" "User
initiated". Same for the skipped reason enum.

[scottmg, 2016-09-27 17:30:08]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[scottmg, 2016-09-27 17:30:26]

+mark for the rest.

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:7461: +  <summary>Counts of crash upload
successes and failures.</summary>
On 2016/09/27 15:48:48, Alexei Svitkine (very slow) wrote:
> Nit: Instead of "counts" which suggests you're logging values like 7, I would
> phrase it as "Logs whether a crash upload succeeded or failed."
> 
> The plural counts is implicit in the aggregation.

Done.

https://codereview.chromium.org/2372593004/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:75067: +  <int value="0"
label="kNewlyCreated"/>
On 2016/09/27 15:48:48, Alexei Svitkine (very slow) wrote:
> Nit: Suggest using human readable strings here - e.g. "Newly created" "User
> initiated". Same for the skipped reason enum.

I would prefer to keep them matching the enum in the code so that it's easier to
figure out when/where/what is going on (especially for SkippedReason).

[Mark Mentovai, 2016-09-27 18:18:22]

LGTM

[scottmg, 2016-09-27 18:20:10]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:21:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:03:35]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2016-09-27 19:08:59]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2016-09-27 19:09:14]

scottmg@chromium.org changed reviewers:
+ siggi@chromium.org

[scottmg, 2016-09-27 19:09:15]

+siggi for components/browser_watcher :/

[commit-bot: I haz the power, 2016-09-27 19:09:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2016-09-27 19:15:41]

lgtm - thanks!

[commit-bot: I haz the power, 2016-09-27 19:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:50:52]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[scottmg, 2016-09-27 19:54:43]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:58:27]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-09-27 21:22:45]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-09-27 21:22:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, mark@chromium.org, siggi@chromium.org
Link to the patchset: https://codereview.chromium.org/2372593004/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-09-27 21:23:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:29:16]

Description was changed from

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100
==========

[commit-bot: I haz the power, 2016-09-27 21:29:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-27 21:31:46]

Description was changed from

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e

ac6c01b5752e Add metrics for tracking uploads

Also update histograms.xml for new UMA.

R=asvitkine@chromium.org
BUG=crashpad:100

Committed: https://crrev.com/a0b3fb78ec4871dca5673c8650baeb96324d1faf
Cr-Commit-Position: refs/heads/master@{#421339}
==========

[commit-bot: I haz the power, 2016-09-27 21:31:47]

Patchset 4 (id:??) landed as
https://crrev.com/a0b3fb78ec4871dca5673c8650baeb96324d1faf
Cr-Commit-Position: refs/heads/master@{#421339}