tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index bd59a3736ca24e08e1b944a6e7c0312172177d39..9c3e47440bade07300016b96eb45a259d1d6f851 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -7443,11 +7443,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <summary>The exit codes for crashed renderer processes.</summary>
 </histogram>
 
+<histogram name="Crashpad.CrashReportPending" enum="CrashpadReportPending">
+  <owner>crashpad-dev@chromium.org</owner>
+  <summary>
+    The reason that a crash report entered the upload pending state.
+  </summary>
+</histogram>
+
 <histogram name="Crashpad.CrashReportSize" units="bytes">
   <owner>crashpad-dev@chromium.org</owner>
   <summary>The size of a crash report minidump on disk when captured.</summary>
 </histogram>
 
+<histogram name="Crashpad.CrashUpload.AttemptSuccessful"
+    enum="CrashpadUploadAttemptStatus">
+  <owner>crashpad-dev@chromium.org</owner>
+  <summary>Counts of crash upload successes and failures.</summary>

[Alexei Svitkine (slow), 2016/09/27 15:48:48]

Nit: Instead of "counts" which suggests you're logging values like 7, I would
phrase it as "Logs whether a crash upload succeeded or failed."

The plural counts is implicit in the aggregation.

[scottmg, 2016/09/27 17:30:26]

Done.

+</histogram>
+
+<histogram name="Crashpad.CrashUpload.Skipped"
+    enum="CrashpadUploadSkippedReason">
+  <owner>crashpad-dev@chromium.org</owner>
+  <summary>The reason that a crash report upload was skipped.</summary>
+</histogram>
+
 <histogram name="Crashpad.ExceptionCaptureResult"
     enum="CrashpadExceptionCaptureResult">
   <owner>crashpad-dev@chromium.org</owner>
@@ -75044,6 +75063,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="10" label="EXC_CRASH"/>
 </enum>
 
+<enum name="CrashpadReportPending" type="int">
+  <int value="0" label="kNewlyCreated"/>

[Alexei Svitkine (slow), 2016/09/27 15:48:48]

Nit: Suggest using human readable strings here - e.g. "Newly created" "User
initiated". Same for the skipped reason enum.

[scottmg, 2016/09/27 17:30:26]

I would prefer to keep them matching the enum in the code so that it's easier to
figure out when/where/what is going on (especially for SkippedReason).

+  <int value="1" label="kUserInitiated"/>
+</enum>
+
+<enum name="CrashpadUploadAttemptStatus" type="int">
+  <int value="0" label="Failed"/>
+  <int value="1" label="Succeeded"/>
+</enum>
+
+<enum name="CrashpadUploadSkippedReason" type="int">
+  <int value="0" label="kUploadsDisabled"/>
+  <int value="1" label="kUploadThrottled"/>
+  <int value="2" label="kUnexpectedTime"/>
+  <int value="3" label="kDatabaseError"/>
+  <int value="4" label="kUploadFailed"/>
+</enum>
+
 <enum name="CreatePersistentHistogramResult" type="int">
   <int value="0" label="Success: Histogram created in persistent space."/>
   <int value="1" label="Error: Invalid metadata pointer. (coding error)"/>