Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: third_party/crashpad/crashpad/client/crash_report_database_mac.mm

Issue 2372593004: Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/crash_report_database_mac.mm
diff --git a/third_party/crashpad/crashpad/client/crash_report_database_mac.mm b/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
index 861a699e83fcd05600cc0b61b3e6e5ef9fb0c9a9..f9c783eb2b11f204ffa16064802ab92db2866675 100644
--- a/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
+++ b/third_party/crashpad/crashpad/client/crash_report_database_mac.mm
@@ -140,7 +140,8 @@ class CrashReportDatabaseMac : public CrashReportDatabase {
OperationStatus RecordUploadAttempt(const Report* report,
bool successful,
const std::string& id) override;
- OperationStatus SkipReportUpload(const UUID& uuid) override;
+ OperationStatus SkipReportUpload(const UUID& uuid,
+ Metrics::CrashSkippedReason reason) override;
OperationStatus DeleteReport(const UUID& uuid) override;
OperationStatus RequestUpload(const UUID& uuid) override;
@@ -359,6 +360,7 @@ CrashReportDatabaseMac::FinishedWritingCrashReport(NewReport* report,
return kFileSystemError;
}
+ Metrics::CrashReportPending(Metrics::PendingReportReason::kNewlyCreated);
Metrics::CrashReportSize(report->handle);
return kNoError;
@@ -451,6 +453,8 @@ CrashReportDatabaseMac::RecordUploadAttempt(const Report* report,
const std::string& id) {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ Metrics::CrashUploadAttempted(successful);
+
DCHECK(report);
DCHECK(successful || id.empty());
@@ -502,9 +506,12 @@ CrashReportDatabaseMac::RecordUploadAttempt(const Report* report,
}
CrashReportDatabase::OperationStatus CrashReportDatabaseMac::SkipReportUpload(
- const UUID& uuid) {
+ const UUID& uuid,
+ Metrics::CrashSkippedReason reason) {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ Metrics::CrashUploadSkipped(reason);
+
base::FilePath report_path = LocateCrashReport(uuid);
if (report_path.empty())
return kReportNotFound;
@@ -597,6 +604,8 @@ CrashReportDatabase::OperationStatus CrashReportDatabaseMac::RequestUpload(
return kFileSystemError;
}
+ Metrics::CrashReportPending(Metrics::PendingReportReason::kUserInitiated);
+
return kNoError;
}

Powered by Google App Engine
This is Rietveld 408576698