Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: third_party/crashpad/crashpad/client/crash_report_database_win.cc

Issue 2372593004: Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/crash_report_database_win.cc
diff --git a/third_party/crashpad/crashpad/client/crash_report_database_win.cc b/third_party/crashpad/crashpad/client/crash_report_database_win.cc
index 5a7db2d1011230b1affdf869db3521ccb1ee1b2d..4fccd3fd22f5cac9b73ceb43fac0afc17e9ea1bc 100644
--- a/third_party/crashpad/crashpad/client/crash_report_database_win.cc
+++ b/third_party/crashpad/crashpad/client/crash_report_database_win.cc
@@ -589,7 +589,8 @@ class CrashReportDatabaseWin : public CrashReportDatabase {
OperationStatus RecordUploadAttempt(const Report* report,
bool successful,
const std::string& id) override;
- OperationStatus SkipReportUpload(const UUID& uuid) override;
+ OperationStatus SkipReportUpload(const UUID& uuid,
+ Metrics::CrashSkippedReason reason) override;
OperationStatus DeleteReport(const UUID& uuid) override;
OperationStatus RequestUpload(const UUID& uuid) override;
@@ -679,6 +680,7 @@ OperationStatus CrashReportDatabaseWin::FinishedWritingCrashReport(
ReportState::kPending));
*uuid = scoped_report->uuid;
+ Metrics::CrashReportPending(Metrics::PendingReportReason::kNewlyCreated);
Metrics::CrashReportSize(handle.get());
return kNoError;
@@ -774,6 +776,8 @@ OperationStatus CrashReportDatabaseWin::RecordUploadAttempt(
const std::string& id) {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ Metrics::CrashUploadAttempted(successful);
+
// Take ownership, allocated in GetReportForUploading.
std::unique_ptr<const Report> upload_report(report);
std::unique_ptr<Metadata> metadata(AcquireMetadata());
@@ -826,9 +830,13 @@ OperationStatus CrashReportDatabaseWin::DeleteReport(const UUID& uuid) {
return kNoError;
}
-OperationStatus CrashReportDatabaseWin::SkipReportUpload(const UUID& uuid) {
+OperationStatus CrashReportDatabaseWin::SkipReportUpload(
+ const UUID& uuid,
+ Metrics::CrashSkippedReason reason) {
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
+ Metrics::CrashUploadSkipped(reason);
+
std::unique_ptr<Metadata> metadata(AcquireMetadata());
if (!metadata)
return kDatabaseError;
@@ -885,6 +893,8 @@ OperationStatus CrashReportDatabaseWin::RequestUpload(const UUID& uuid) {
report_disk->upload_explicitly_requested = true;
report_disk->state = ReportState::kPending;
+ Metrics::CrashReportPending(Metrics::PendingReportReason::kUserInitiated);
+
return kNoError;
}

Powered by Google App Engine
This is Rietveld 408576698