Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/crashpad/crashpad/client/crash_report_database_test.cc

Issue 2372593004: Update Crashpad to ac6c01b5752ecb1aa1da0ea613740cf6825bb72e (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/crash_report_database_test.cc
diff --git a/third_party/crashpad/crashpad/client/crash_report_database_test.cc b/third_party/crashpad/crashpad/client/crash_report_database_test.cc
index 200619d2fa618037fe1aa989bd081b2822a6b4ee..72804643e76ceb5e3ddfb1bf5d7889d3507e5e0a 100644
--- a/third_party/crashpad/crashpad/client/crash_report_database_test.cc
+++ b/third_party/crashpad/crashpad/client/crash_report_database_test.cc
@@ -433,7 +433,8 @@ TEST_F(CrashReportDatabaseTest, GetCompletedAndNotUploadedReports) {
// Skip upload for one report.
EXPECT_EQ(CrashReportDatabase::kNoError,
- db()->SkipReportUpload(report_3_uuid));
+ db()->SkipReportUpload(
+ report_3_uuid, Metrics::CrashSkippedReason::kUploadsDisabled));
pending.clear();
EXPECT_EQ(CrashReportDatabase::kNoError, db()->GetPendingReports(&pending));
@@ -608,7 +609,8 @@ TEST_F(CrashReportDatabaseTest, RequestUpload) {
// Skipped report gets back to pending state after RequestUpload is called.
EXPECT_EQ(CrashReportDatabase::kNoError,
- db()->SkipReportUpload(report_1_uuid));
+ db()->SkipReportUpload(
+ report_1_uuid, Metrics::CrashSkippedReason::kUploadsDisabled));
std::vector<CrashReportDatabase::Report> pending_reports;
CrashReportDatabase::OperationStatus os =
@@ -643,7 +645,8 @@ TEST_F(CrashReportDatabaseTest, RequestUpload) {
// Explicitly requested reports will not have upload_explicitly_requested bit
// after getting skipped.
EXPECT_EQ(CrashReportDatabase::kNoError,
- db()->SkipReportUpload(report_1_uuid));
+ db()->SkipReportUpload(
+ report_1_uuid, Metrics::CrashSkippedReason::kUploadsDisabled));
CrashReportDatabase::Report report;
EXPECT_EQ(CrashReportDatabase::kNoError,
db()->LookUpCrashReport(report_1_uuid, &report));

Powered by Google App Engine
This is Rietveld 408576698