Revert 222102 "Remove unsafe access hacks from ScopedPersistent."

Revert 222102 "Remove unsafe access hacks from ScopedPersistent."

ActivityLogPrerenderTest.TestScriptInjected browser test failed on win xp.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39433

> Remove unsafe access hacks from ScopedPersistent.
> 
> BUG=236290
> 
> Review URL: https://chromiumcodereview.appspot.com/23636015

TBR=marja@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222151

[please use gerrit instead, 2013-09-10 00:35:25]

Committed patchset #1 manually as r222151.

[marja, 2013-09-10 06:49:57]

Some data from the build bot:

The first failing build is
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...,
and the reverted commit is on the blame list. The next build,
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...
also fails (i.e., the same test fails).

However, the next build after that,
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...
, succeeds, even though the revert is not yet in. And the next:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...
too.

Then the revert is in:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

Since the test started passing already before my commit was reverted, I assume
that my commit is not guilty, and try to re-land it.

[marja, 2013-09-10 09:00:58]

Huh, the build links don't look like they work :(

Trying again:

The builder:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(dbg)(3)

First failing: 39433

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

Fails again: 39434

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

Succeeds, but revert not yet in: 39435

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

Succeeds again: 39436

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

Revert is in: 39437

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%...

[please use gerrit instead, 2013-09-10 16:30:48]

If the revert was not necessary, then please reland. Sorry for the
inconvenience.


On Tue, Sep 10, 2013 at 2:00 AM, <marja@chromium.org> wrote:

> Huh, the build links don't look like they work :(
>
> Trying again:
>
> The builder:
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20(dbg)(3)<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(dbg)(3)>
>
> First failing: 39433
>
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20%28dbg%29%283%29/**builds/39433<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39433>
>
> Fails again: 39434
>
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20%28dbg%29%283%29/**builds/39434<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39434>
>
> Succeeds, but revert not yet in: 39435
>
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20%28dbg%29%283%29/**builds/39435<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39435>
>
> Succeeds again: 39436
>
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20%28dbg%29%283%29/**builds/39436<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39436>
>
> Revert is in: 39437
>
> http://build.chromium.org/p/**chromium.win/builders/XP%**
>
20Tests%20%28dbg%29%283%29/**builds/39437<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39437>
>
>
https://codereview.chromium.**org/23724028/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.