Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: trunk/src/chrome/renderer/extensions/v8_schema_registry.cc

Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/renderer/extensions/scoped_persistent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/renderer/extensions/v8_schema_registry.cc
===================================================================
--- trunk/src/chrome/renderer/extensions/v8_schema_registry.cc (revision 222150)
+++ trunk/src/chrome/renderer/extensions/v8_schema_registry.cc (working copy)
@@ -108,12 +108,12 @@
v8::Isolate* isolate) {
// It's ok to create local handles in this function, since this is only called
// when we have a HandleScope.
- if (context_.IsEmpty()) {
+ if (context_.get().IsEmpty()) {
v8::Handle<v8::Context> context = v8::Context::New(isolate);
context_.reset(context);
return context;
}
- return context_.NewHandle(isolate);
+ return v8::Local<v8::Context>::New(isolate, context_.get());
}
} // namespace extensions
« no previous file with comments | « trunk/src/chrome/renderer/extensions/scoped_persistent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698