trunk/src/chrome/renderer/extensions/render_view_observer_natives.cc - Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/renderer/extensions/render_view_observer_natives.cc

Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/renderer/extensions/render_view_observer_natives.cc

===================================================================

--- trunk/src/chrome/renderer/extensions/render_view_observer_natives.cc (revision 222150)

+++ trunk/src/chrome/renderer/extensions/render_view_observer_natives.cc (working copy)

@@ -40,7 +40,7 @@

void CallbackAndDie(bool succeeded) {

v8::HandleScope handle_scope(context_->isolate());

v8::Handle<v8::Value> args[] = { v8::Boolean::New(succeeded) };

- context_->CallFunction(callback_.NewHandle(context_->isolate()), 1, args);

+ context_->CallFunction(callback_.get(), 1, args);

delete this;

}