Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/renderer/extensions/chrome_v8_context.cc

Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/renderer/extensions/chrome_v8_context.h ('k') | trunk/src/chrome/renderer/extensions/messaging_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/renderer/extensions/chrome_v8_context.cc
===================================================================
--- trunk/src/chrome/renderer/extensions/chrome_v8_context.cc (revision 222150)
+++ trunk/src/chrome/renderer/extensions/chrome_v8_context.cc (working copy)
@@ -143,7 +143,7 @@
v8::Integer::New(request_id),
v8::String::New(name.c_str()),
v8::Boolean::New(success),
- converter->ToV8Value(&response, v8_context_.NewHandle(isolate())),
+ converter->ToV8Value(&response, v8_context_.get()),
v8::String::New(error.c_str())
};
« no previous file with comments | « trunk/src/chrome/renderer/extensions/chrome_v8_context.h ('k') | trunk/src/chrome/renderer/extensions/messaging_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698