Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: trunk/src/chrome/renderer/extensions/messaging_bindings.cc

Issue 23724028: Revert 222102 "Remove unsafe access hacks from ScopedPersistent." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/renderer/extensions/messaging_bindings.cc
===================================================================
--- trunk/src/chrome/renderer/extensions/messaging_bindings.cc (revision 222150)
+++ trunk/src/chrome/renderer/extensions/messaging_bindings.cc (working copy)
@@ -192,13 +192,12 @@
void RunCallback() {
v8::HandleScope handle_scope(isolate_);
- v8::Handle<v8::Function> callback = callback_.NewHandle(isolate_);
- v8::Handle<v8::Context> context = callback->CreationContext();
+ v8::Handle<v8::Context> context = callback_->CreationContext();
if (context.IsEmpty())
return;
v8::Context::Scope context_scope(context);
WebKit::WebScopedMicrotaskSuppression suppression;
- callback->Call(context->Global(), 0, NULL);
+ callback_->Call(context->Global(), 0, NULL);
}
extensions::ScopedPersistent<v8::Object> object_;

Powered by Google App Engine
This is Rietveld 408576698