[Chromecast] Correct some Cast dependencies in //chrome/browser/ui.

[Chromecast] Correct some Cast dependencies in //chrome/browser/ui.

A recent CL introduced some new GN dependencies that broke internal Cast
variants:
  https://codereview.chromium.org/2354633002

Correct the dependencies here. Also put stronger asserts in x11 targets.

BUG=

Committed: https://crrev.com/549eb8a2f05daf2373d2b4a45b012db76da2d4a2
Cr-Commit-Position: refs/heads/master@{#422860}

[slan, 2016-09-25 19:33:07]

slan@chromium.org changed reviewers:
+ brettw@chromium.org, spang@chromium.org

[slan, 2016-09-25 19:33:08]

Hey Brett, PTAL, this breaks our chromium TOT roller.

+Michael for ui/ changes

[slan, 2016-09-25 19:35:31]

+jyw, esum for FYI

[slan, 2016-09-26 13:34:32]

slan@chromium.org changed reviewers:
+ halliwell@chromium.org

[slan, 2016-09-26 13:34:32]

+Luke

[slan, 2016-09-30 11:21:41]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 11:21:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slan, 2016-09-30 11:21:51]

Ping!

[commit-bot: I haz the power, 2016-09-30 12:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 12:12:47]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-30 21:32:01]

Sorry I lost this.

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:3326: if (is_cast_desktop_build) {
Does your build set use_x11? If so, can we just move these to the use_x11 block
above?

[brettw, 2016-09-30 21:32:01]

Sorry I lost this.

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:3326: if (is_cast_desktop_build) {
Does your build set use_x11? If so, can we just move these to the use_x11 block
above?

[slan, 2016-10-03 23:42:58]

PS2 removes the need for all but two of the dependencies via more "correct"
methods - moving source files inside conditional blocks, using feature guards to
include headers, etc.

The "//ui/views" targets are too pervasive to cleanly remove, so we sadly need
to keep those in there.

PTAL!

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2371583002/diff/1/chrome/browser/ui/BUILD.gn#...
chrome/browser/ui/BUILD.gn:3326: if (is_cast_desktop_build) {
On 2016/09/30 21:32:01, brettw (ping on IM after 24h) wrote:
> Does your build set use_x11? If so, can we just move these to the use_x11
block
> above?

It doesn't. So I moved the violating source files inside a use_x11 block,
preventing the need for these additional dependencies altogether.

[slan, 2016-10-03 23:42:58]

PS2 removes the need for all but two of the dependencies via more "correct"
methods - moving source files inside conditional blocks, using feature guards to
include headers, etc.

The "//ui/views" targets are too pervasive to cleanly remove, so we sadly need
to keep those in there.

PTAL!

[slan, 2016-10-03 23:46:44]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 03:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:09:39]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-04 03:38:50]

Thanks. LGTM

[slan, 2016-10-04 18:15:57]

The CQ bit was checked by slan@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:16:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 18:22:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 18:25:22]

Description was changed from

==========
[Chromecast] Correct some Cast dependencies in //chrome/browser/ui.

A recent CL introduced some new GN dependencies that broke internal Cast
variants:
  https://codereview.chromium.org/2354633002

Correct the dependencies here. Also put stronger asserts in x11 targets.

BUG=
==========

to

==========
[Chromecast] Correct some Cast dependencies in //chrome/browser/ui.

A recent CL introduced some new GN dependencies that broke internal Cast
variants:
  https://codereview.chromium.org/2354633002

Correct the dependencies here. Also put stronger asserts in x11 targets.

BUG=

Committed: https://crrev.com/549eb8a2f05daf2373d2b4a45b012db76da2d4a2
Cr-Commit-Position: refs/heads/master@{#422860}
==========

[commit-bot: I haz the power, 2016-10-04 18:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/549eb8a2f05daf2373d2b4a45b012db76da2d4a2
Cr-Commit-Position: refs/heads/master@{#422860}