[Chromecast] Correct some Cast dependencies in //chrome/browser/ui.

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1129 matching lines @@
       "webui/uber/uber_ui.h",
       "window_sizer/window_sizer.cc",
       "window_sizer/window_sizer.h",
     ]
     deps += [
       "//apps",
       "//chrome/browser/profile_resetter:profile_reset_report_proto",
       "//chrome/common:features",
       "//components/feedback/proto",
       "//components/proximity_auth/webui",
+      "//components/web_modal",
       "//device/bluetooth",
       "//mash/public/interfaces",
     ]
   }
 
   if (enable_basic_printing || enable_print_preview) {
     deps += [ "//printing" ]
   }
 
   if (enable_nacl) {
@@ skipping 1804 matching lines @@
     ]
     if (!is_chrome_branded) {
       deps -= [ "//google_update" ]
       sources -= [ "webui/help/version_updater_win.cc" ]
       sources += [
         "webui/help/version_updater_basic.cc",
         "webui/help/version_updater_basic.h",
       ]
     }
   } else {  # 'OS!="win"
-    if (toolkit_views) {
+    # The Cast Linux build sets toolkit_views to false, but many files in this
+    # target include views-related files unconditionally, causing `gn check`
+    # to fail on this variant. Since this target is only referenced (but not
+    # compiled) on this variant, it's okay to add this "incorrect" dependency
+    # to Cast Linux builds so that `gn check` passes.
+    if (toolkit_views || (is_chromecast && is_linux)) {
       public_deps += [
         "//ui/views",
         "//ui/views/controls/webview",
       ]
     }
   }
   if (is_desktop_linux) {
     sources += [
       "input_method/input_method_engine.cc",
       "input_method/input_method_engine.h",
       "input_method/input_method_engine_base.cc",
       "input_method/input_method_engine_base.h",
       "views/apps/chrome_app_window_client_views_linux.cc",
       "views/first_run_dialog.cc",
       "views/first_run_dialog.h",
       "views/frame/browser_desktop_window_tree_host.h",
-      "views/frame/browser_desktop_window_tree_host_x11.cc",
-      "views/frame/browser_desktop_window_tree_host_x11.h",
       "views/frame/desktop_browser_frame_auralinux.cc",
       "views/frame/desktop_browser_frame_auralinux.h",
-      "views/frame/global_menu_bar_registrar_x11.cc",
-      "views/frame/global_menu_bar_registrar_x11.h",
-      "views/frame/global_menu_bar_x11.cc",
-      "views/frame/global_menu_bar_x11.h",
       "views/frame/native_browser_frame_factory_auralinux.cc",
-      "views/javascript_app_modal_dialog_views_x11.cc",
-      "views/javascript_app_modal_dialog_views_x11.h",
       "views/status_icons/status_icon_linux_wrapper.cc",
       "views/status_icons/status_icon_linux_wrapper.h",
       "webui/help/version_updater_basic.cc",
       "webui/help/version_updater_basic.h",
     ]
     deps += [
       "//ui/base/ime",
       "//ui/events:dom_keycode_converter",
     ]
+
+    if (use_x11) {
+      sources += [
+        "views/frame/browser_desktop_window_tree_host_x11.cc",
+        "views/frame/browser_desktop_window_tree_host_x11.h",
+        "views/frame/global_menu_bar_registrar_x11.cc",
+        "views/frame/global_menu_bar_registrar_x11.h",
+        "views/frame/global_menu_bar_x11.cc",
+        "views/frame/global_menu_bar_x11.h",
+        "views/javascript_app_modal_dialog_views_x11.cc",
+        "views/javascript_app_modal_dialog_views_x11.h",
+      ]
+    }
   }
   if (is_linux) {  # Both desktop Linux and ChromeOS.
     sources += [
       "certificate_dialogs.cc",
       "certificate_dialogs.h",
       "webui/certificate_viewer_ui.cc",
       "webui/certificate_viewer_ui.h",
       "webui/certificate_viewer_webui.cc",
       "webui/certificate_viewer_webui.h",
     ]
@@ skipping 309 matching lines @@
     ]
   }
   if (enable_service_discovery) {
     sources += [
       "webui/local_discovery/local_discovery_ui.cc",
       "webui/local_discovery/local_discovery_ui.h",
       "webui/local_discovery/local_discovery_ui_handler.cc",
       "webui/local_discovery/local_discovery_ui_handler.h",
     ]
   }
-
-  if (is_chromecast && is_linux) {
-    # The Chromecast build sets toolkit_views to false but some targets in the
-    # build still reference views. But this target is referenced on the Cast
-    # bot (though not currently compiled) but is configured as Linux. This
-    # necessitates these extra dependencies to pass "gn check".
-    deps += [
-      "//chrome/browser/media/router",
-      "//components/web_modal",
-      "//ui/base/x",
-      "//ui/events/devices/x11",
-      "//ui/events/keycodes:x11",
-      "//ui/views",
-      "//ui/views/controls/webview",
-    ]
-  }
 }
 
 # In GYP this is part of test_support_common.
 static_library("test_support") {
   testonly = true
 
   sources = [
     "cocoa/cocoa_test_helper.h",
     "cocoa/cocoa_test_helper.mm",
     "cocoa/run_loop_testing.h",
@@ skipping 68 matching lines @@
       "passwords/passwords_model_delegate_mock.cc",
       "passwords/passwords_model_delegate_mock.h",
     ]
     deps += [ "//chrome/test:test_support_ui" ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }