Add //chrome/browser/ui to "gn check".

Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to this target.

Committed: https://crrev.com/3ac5672baf63a05022559a7230d3a5b1c5510a72
Cr-Commit-Position: refs/heads/master@{#419568}

[brettw, 2016-09-19 17:39:22]

Windows

[brettw, 2016-09-19 17:40:18]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:40:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-19 17:40:53]

Description was changed from

==========
Add //chrome/browser/ui to "gn check".

BUG=
==========

to

==========
Add //chrome/browser/ui to "gn check".

Also adds a "no deps" annotation chrome chrome/browser to V8. This seems to be
possible now.

BUG=581766
==========

[brettw, 2016-09-19 17:40:53]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:44:29]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-09-19 17:53:35]

Description was changed from

==========
Add //chrome/browser/ui to "gn check".

Also adds a "no deps" annotation chrome chrome/browser to V8. This seems to be
possible now.

BUG=581766
==========

to

==========
Add //chrome/browser/ui to "gn check".
==========

[brettw, 2016-09-19 17:54:20]

Re-comment-out V8

[brettw, 2016-09-19 17:54:21]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:54:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-19 17:57:53]

Should I wait for green trybots?

[commit-bot: I haz the power, 2016-09-19 17:58:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:58:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-09-19 19:19:36]

Fix

[brettw, 2016-09-19 19:19:36]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-09-19 19:19:40]

Description was changed from

==========
Add //chrome/browser/ui to "gn check".
==========

to

==========
Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to
this target.
==========

[brettw, 2016-09-19 19:20:03]

I wouldn't, any changes from here should be trivial.

(More info now in the summary.)

[commit-bot: I haz the power, 2016-09-19 19:20:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-19 19:23:54]

LGTM

[commit-bot: I haz the power, 2016-09-19 19:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:24:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-09-19 19:28:20]

Android

[brettw, 2016-09-19 19:28:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-19 19:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2354633002/#ps80001
(title: "Android")

[commit-bot: I haz the power, 2016-09-19 19:29:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:35:03]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[brettw, 2016-09-19 20:27:35]

fixes

[brettw, 2016-09-19 20:27:36]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-19 20:27:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2354633002/#ps100001
(title: "fixes")

[commit-bot: I haz the power, 2016-09-19 20:28:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:36:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:36:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-09-19 20:42:58]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-19 20:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2354633002/#ps120001
(title: "cast_shell_android and chromeos_ozone")

[commit-bot: I haz the power, 2016-09-19 20:43:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:41:55]

Description was changed from

==========
Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to
this target.
==========

to

==========
Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to
this target.
==========

[commit-bot: I haz the power, 2016-09-19 21:41:56]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-19 21:45:29]

Description was changed from

==========
Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to
this target.
==========

to

==========
Add //chrome/browser/ui to "gn check".

Adds some missing dependencies, converts some to public.

Adds a chrome_dll_resource target and move all direct includes of this header to
this target.

Committed: https://crrev.com/3ac5672baf63a05022559a7230d3a5b1c5510a72
Cr-Commit-Position: refs/heads/master@{#419568}
==========

[commit-bot: I haz the power, 2016-09-19 21:45:30]

Patchset 7 (id:??) landed as
https://crrev.com/3ac5672baf63a05022559a7230d3a5b1c5510a72
Cr-Commit-Position: refs/heads/master@{#419568}