Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: chrome/browser/ui/BUILD.gn

Issue 2371583002: [Chromecast] Correct some Cast dependencies in //chrome/browser/ui. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/base/x/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chromecast_build.gni") 5 import("//build/config/chromecast_build.gni")
6 import("//build/config/crypto.gni") 6 import("//build/config/crypto.gni")
7 import("//build/config/features.gni") 7 import("//build/config/features.gni")
8 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
9 import("//build/split_static_library.gni") 9 import("//build/split_static_library.gni")
10 import("//chrome/common/features.gni") 10 import("//chrome/common/features.gni")
(...skipping 3305 matching lines...) Expand 10 before | Expand all | Expand 10 after
3316 if (enable_service_discovery) { 3316 if (enable_service_discovery) {
3317 sources += [ 3317 sources += [
3318 "webui/local_discovery/local_discovery_ui.cc", 3318 "webui/local_discovery/local_discovery_ui.cc",
3319 "webui/local_discovery/local_discovery_ui.h", 3319 "webui/local_discovery/local_discovery_ui.h",
3320 "webui/local_discovery/local_discovery_ui_handler.cc", 3320 "webui/local_discovery/local_discovery_ui_handler.cc",
3321 "webui/local_discovery/local_discovery_ui_handler.h", 3321 "webui/local_discovery/local_discovery_ui_handler.h",
3322 ] 3322 ]
3323 } 3323 }
3324 3324
3325 if (is_chromecast && is_linux) { 3325 if (is_chromecast && is_linux) {
3326 if (is_cast_desktop_build) {
brettw 2016/09/30 21:32:01 Does your build set use_x11? If so, can we just mo
slan 2016/10/03 23:42:57 It doesn't. So I moved the violating source files
3327 deps += [
3328 "//ui/base/x",
3329 "//ui/events/devices/x11",
3330 "//ui/events/keycodes:x11",
3331 ]
3332 }
3333
3326 # The Chromecast build sets toolkit_views to false but some targets in the 3334 # The Chromecast build sets toolkit_views to false but some targets in the
3327 # build still reference views. But this target is referenced on the Cast 3335 # build still reference views. But this target is referenced on the Cast
3328 # bot (though not currently compiled) but is configured as Linux. This 3336 # bot (though not currently compiled) but is configured as Linux. This
3329 # necessitates these extra dependencies to pass "gn check". 3337 # necessitates these extra dependencies to pass "gn check".
3330 deps += [ 3338 deps += [
3331 "//chrome/browser/media/router", 3339 "//chrome/browser/media/router",
3332 "//components/web_modal", 3340 "//components/web_modal",
3333 "//ui/base/x",
3334 "//ui/events/devices/x11",
3335 "//ui/events/keycodes:x11",
3336 "//ui/views", 3341 "//ui/views",
3337 "//ui/views/controls/webview", 3342 "//ui/views/controls/webview",
3338 ] 3343 ]
3339 } 3344 }
3340 } 3345 }
3341 3346
3342 # In GYP this is part of test_support_common. 3347 # In GYP this is part of test_support_common.
3343 static_library("test_support") { 3348 static_library("test_support") {
3344 testonly = true 3349 testonly = true
3345 3350
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
3418 "passwords/passwords_model_delegate_mock.cc", 3423 "passwords/passwords_model_delegate_mock.cc",
3419 "passwords/passwords_model_delegate_mock.h", 3424 "passwords/passwords_model_delegate_mock.h",
3420 ] 3425 ]
3421 deps += [ "//chrome/test:test_support_ui" ] 3426 deps += [ "//chrome/test:test_support_ui" ]
3422 } 3427 }
3423 3428
3424 if (enable_extensions) { 3429 if (enable_extensions) {
3425 deps += [ "//extensions/browser" ] 3430 deps += [ "//extensions/browser" ]
3426 } 3431 }
3427 } 3432 }
OLDNEW
« no previous file with comments | « no previous file | ui/base/x/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698