Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList

Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList.

BUG=268984
TEST= no functional change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227534

[Cait (Slow), 2013-10-02 21:59:40]

This is a second attempt at this CL (using CallbackList, now that we have it). 

Peter: PTAL at c/b/search_engines/
Avi: Could you give the rest a quick once-over, then I'll get a Chrome/ owner to
rubber stamp?

Thanks!

[Peter Kasting, 2013-10-02 22:22:03]

c/b/search_engines LGTM

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:786:
TemplateURLService::RegisterOnLoadedCallback(
Nit: Indent 4

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:788: if (loaded_)
Nit: I very slightly prefer:

  return loaded_ ?
      scoped_ptr<TemplateURLService::Subscription>() :
      on_loaded_callbacks_.Add(callback);

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:1588:
on_loaded_callbacks_.Notify();
Nit: At this point, we can just nuke NotifyLoaded() and inline this line into
the callers directly.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.cc:137:
Java_TemplateUrlService_templateUrlServiceLoaded(env,
Nit: Move this arg to the next line so we don't have 2 lines of args that begin
at different columns

[Avi (use Gerrit), 2013-10-02 22:27:52]

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:164:
* Registers a listener for the callback once TemplateURLService has
This sentence is ambiguous. Does the registration happen when TemplateURLService
has loaded, or does the callback happen?

How about:

Registers a listener for the callback that indicates that the TemplateURLService
has loaded.

(Assuming that that is the correct disambiguation...)

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:175:
* loaded.
ditto

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:669: // TODO(brettw) bug
1139736: This should also observe session
Can you migrate this bug out of buganizer?

And this comment no longer belongs here as this is now strictly a "keywords
loaded" callback rather than a "something happened" callback. You'll need to
find a new location for it.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:674: // else notifies,
observers and deletes this BrowsingDataRemover.
Misplaced comma; do: "...else, notifies observers..."

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.h:216: // Callback when
TemplateURLService has finished loading.
"Callback for when..."?

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/extensions...
File chrome/browser/extensions/api/omnibox/omnibox_api.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/extensions...
chrome/browser/extensions/api/omnibox/omnibox_api.h:13: #include
"base/memory/weak_ptr.h"
not used; don't include

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/importer/e...
File chrome/browser/importer/external_process_importer_host.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/importer/e...
chrome/browser/importer/external_process_importer_host.h:113:
base::WeakPtrFactory<ExternalProcessImporterHost> weak_ptr_factory_;
Yikes! This needs to be the last member variable.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.cc:251: // TemplateURLService
has loaded. If we need to clean search engines, it's
Was the drop of the thread DCHECK intentional? Might as well leave it be.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.h:10: #include
"base/memory/weak_ptr.h"
not used; remove.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_scraper_unittest.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_scraper_unittest.cc:32:
content::RunMessageLoop();
Er... This smells. Do you want MessageLoopRunner? Something like:

scoped_refptr<content::MessageLoopRunner> message_loop_runner = new
content::MessageLoopRunner;
scoped_ptr<TemplateURLService::Subscription> subscription =
        model_->RegisterOnLoadedCallback(
            message_loop_runner->QuitClosure());
model_->Load();
message_loop_runner->Run();

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.cc:51: // Cleanup
for our extra registrar usage.
The comment is bogus; there is no registrar and there isn't even any cleanup
here.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:271:
content::RunThisRunLoop(&run_loop);
Again, MessageLoopRunner?

https://codereview.chromium.org/23710022/diff/40001/chrome/test/base/ui_test_...
File chrome/test/base/ui_test_utils.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/test/base/ui_test_...
chrome/test/base/ui_test_utils.cc:364: content::RunThisRunLoop(&run_loop);
MessageLoopRunner

[Cait (Slow), 2013-10-03 15:36:45]

Thanks all for the speedy (and thorough) reviews!

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
File
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
(right):

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:164:
* Registers a listener for the callback once TemplateURLService has
On 2013/10/02 22:27:52, Avi wrote:
> This sentence is ambiguous. Does the registration happen when
TemplateURLService
> has loaded, or does the callback happen?
> 
> How about:
> 
> Registers a listener for the callback that indicates that the
TemplateURLService
> has loaded.
> 
> (Assuming that that is the correct disambiguation...)

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/android/java/src/o...
chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java:175:
* loaded.
On 2013/10/02 22:27:52, Avi wrote:
> ditto

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:669: // TODO(brettw) bug
1139736: This should also observe session
On 2013/10/02 22:27:52, Avi wrote:
> Can you migrate this bug out of buganizer?
> 
> And this comment no longer belongs here as this is now strictly a "keywords
> loaded" callback rather than a "something happened" callback. You'll need to
> find a new location for it.

brettw: Is this buganizer issue still relevant? If so, I'll migrate to crbug,
otherwise I'll remove the TODO. -- Thanks!

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:674: // else notifies,
observers and deletes this BrowsingDataRemover.
On 2013/10/02 22:27:52, Avi wrote:
> Misplaced comma; do: "...else, notifies observers..."

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.h:216: // Callback when
TemplateURLService has finished loading.
On 2013/10/02 22:27:52, Avi wrote:
> "Callback for when..."?

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/extensions...
File chrome/browser/extensions/api/omnibox/omnibox_api.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/extensions...
chrome/browser/extensions/api/omnibox/omnibox_api.h:13: #include
"base/memory/weak_ptr.h"
On 2013/10/02 22:27:52, Avi wrote:
> not used; don't include

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/importer/e...
File chrome/browser/importer/external_process_importer_host.h (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/importer/e...
chrome/browser/importer/external_process_importer_host.h:113:
base::WeakPtrFactory<ExternalProcessImporterHost> weak_ptr_factory_;
On 2013/10/02 22:27:52, Avi wrote:
> Yikes! This needs to be the last member variable.

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.cc:251: // TemplateURLService
has loaded. If we need to clean search engines, it's
On 2013/10/02 22:27:52, Avi wrote:
> Was the drop of the thread DCHECK intentional? Might as well leave it be.

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_scraper_unittest.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_scraper_unittest.cc:32:
content::RunMessageLoop();
On 2013/10/02 22:27:52, Avi wrote:
> Er... This smells. Do you want MessageLoopRunner? Something like:
> 
> scoped_refptr<content::MessageLoopRunner> message_loop_runner = new
> content::MessageLoopRunner;
> scoped_ptr<TemplateURLService::Subscription> subscription =
>         model_->RegisterOnLoadedCallback(
>             message_loop_runner->QuitClosure());
> model_->Load();
> message_loop_runner->Run();

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:786:
TemplateURLService::RegisterOnLoadedCallback(
On 2013/10/02 22:22:04, Peter Kasting wrote:
> Nit: Indent 4

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:788: if (loaded_)
On 2013/10/02 22:22:04, Peter Kasting wrote:
> Nit: I very slightly prefer:
> 
>   return loaded_ ?
>       scoped_ptr<TemplateURLService::Subscription>() :
>       on_loaded_callbacks_.Add(callback);

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service.cc:1588:
on_loaded_callbacks_.Notify();
On 2013/10/02 22:22:04, Peter Kasting wrote:
> Nit: At this point, we can just nuke NotifyLoaded() and inline this line into
> the callers directly.

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.cc:137:
Java_TemplateUrlService_templateUrlServiceLoaded(env,
On 2013/10/02 22:22:04, Peter Kasting wrote:
> Nit: Move this arg to the next line so we don't have 2 lines of args that
begin
> at different columns

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.cc:51: // Cleanup
for our extra registrar usage.
On 2013/10/02 22:27:52, Avi wrote:
> The comment is bogus; there is no registrar and there isn't even any cleanup
> here.

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:271:
content::RunThisRunLoop(&run_loop);
On 2013/10/02 22:27:52, Avi wrote:
> Again, MessageLoopRunner?

Done.

https://codereview.chromium.org/23710022/diff/40001/chrome/test/base/ui_test_...
File chrome/test/base/ui_test_utils.cc (right):

https://codereview.chromium.org/23710022/diff/40001/chrome/test/base/ui_test_...
chrome/test/base/ui_test_utils.cc:364: content::RunThisRunLoop(&run_loop);
On 2013/10/02 22:27:52, Avi wrote:
> MessageLoopRunner

Done.

[Cait (Slow), 2013-10-03 15:38:55]

Brett: see comment in browsing_data_remover.

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.cc (right):

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:226: // clearing (what
about other things such as passwords, etc.?) and wait for
brettw: Is this buganizer bug still relevant? If so, I'll migrate to crbug, o.w.
I'll remove the TODO -- thanks!

[Avi (use Gerrit), 2013-10-03 17:53:51]

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_scraper_unittest.cc (right):

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_scraper_unittest.cc:31:
message_loop_runner->Run();
Er... this block of code is outside any function. You probably want to remove it
:)

[Cait (Slow), 2013-10-03 20:39:14]

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_scraper_unittest.cc (right):

https://codereview.chromium.org/23710022/diff/56001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_scraper_unittest.cc:31:
message_loop_runner->Run();
On 2013/10/03 17:53:51, Avi wrote:
> Er... this block of code is outside any function. You probably want to remove
it
> :)

oops.

[Avi (use Gerrit), 2013-10-03 20:53:08]

LGTM

[Cait (Slow), 2013-10-03 21:19:49]

thestig: PTAL. Avi has reviewed the whole CL, so it just needs a chrome/ OWNERS
approval -- Thanks!

[Lei Zhang, 2013-10-08 00:25:20]

lgtm

just nit picking:

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:677:
DCHECK(model->profile() == profile_);
DCHECK_EQ() ?

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/importer/e...
File chrome/browser/importer/external_process_importer_host.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/importer/e...
chrome/browser/importer/external_process_importer_host.h:131: // True if we're
waiting for the TemplateURLService to finish loading.
"True if" is not exactly right for non bools. How about:

// May contain a Subscription waiting for the TemplateURLService to finish
loading.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.h:16: class TemplateURLService;
no longer needed since you are including template_url_service.h

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_fetcher.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_fetcher.cc:28: : public
net::URLFetcherDelegate {
fits on the prev line

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.cc:38: if
(template_url_service_) {
Is this ever false?

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.h:14: class
TemplateURLService;
fwd-decl no longer needed

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.h:47: virtual
~TemplateUrlServiceAndroid();
no longer need to be virtual

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.cc:52:
template_url_subscription_.reset();
Preferably do the DCHECKs first.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.h:34:
scoped_ptr<TemplateURLService::Subscription> template_url_subscription_;
include scoped_ptr.h

[Cait (Slow), 2013-10-08 15:09:31]

Thanks!

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/browsing_d...
File chrome/browser/browsing_data/browsing_data_remover.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/browsing_d...
chrome/browser/browsing_data/browsing_data_remover.cc:677:
DCHECK(model->profile() == profile_);
On 2013/10/08 00:25:20, Lei Zhang wrote:
> DCHECK_EQ() ?

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/importer/e...
File chrome/browser/importer/external_process_importer_host.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/importer/e...
chrome/browser/importer/external_process_importer_host.h:131: // True if we're
waiting for the TemplateURLService to finish loading.
On 2013/10/08 00:25:20, Lei Zhang wrote:
> "True if" is not exactly right for non bools. How about:
> 
> // May contain a Subscription waiting for the TemplateURLService to finish
> loading.

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/profile_re...
File chrome/browser/profile_resetter/profile_resetter.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/profile_re...
chrome/browser/profile_resetter/profile_resetter.h:16: class TemplateURLService;
On 2013/10/08 00:25:20, Lei Zhang wrote:
> no longer needed since you are including template_url_service.h

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_fetcher.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_fetcher.cc:28: : public
net::URLFetcherDelegate {
On 2013/10/08 00:25:20, Lei Zhang wrote:
> fits on the prev line

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.cc:38: if
(template_url_service_) {
On 2013/10/08 00:25:20, Lei Zhang wrote:
> Is this ever false?

Looking at how it is used throughout the code, it would appear not. Removing the
check.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
File chrome/browser/search_engines/template_url_service_android.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.h:14: class
TemplateURLService;
On 2013/10/08 00:25:20, Lei Zhang wrote:
> fwd-decl no longer needed

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/search_eng...
chrome/browser/search_engines/template_url_service_android.h:47: virtual
~TemplateUrlServiceAndroid();
On 2013/10/08 00:25:20, Lei Zhang wrote:
> no longer need to be virtual

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.cc (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.cc:52:
template_url_subscription_.reset();
On 2013/10/08 00:25:20, Lei Zhang wrote:
> Preferably do the DCHECKs first.

Done.

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
File chrome/browser/sync/glue/search_engine_data_type_controller.h (right):

https://codereview.chromium.org/23710022/diff/93001/chrome/browser/sync/glue/...
chrome/browser/sync/glue/search_engine_data_type_controller.h:34:
scoped_ptr<TemplateURLService::Subscription> template_url_subscription_;
On 2013/10/08 00:25:20, Lei Zhang wrote:
> include scoped_ptr.h

Done.

[commit-bot: I haz the power, 2013-10-08 15:10:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/23710022/112001

[commit-bot: I haz the power, 2013-10-08 17:29:12]

Change committed as 227534