Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList

chrome/browser/search_engines/template_url_scraper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
-#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/notification_source.h"
 #include "net/base/net_util.h"
 #include "net/dns/mock_host_resolver.h"
 
 namespace {
 class TemplateURLScraperTest : public InProcessBrowserTest {
  public:
   TemplateURLScraperTest() {
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TemplateURLScraperTest);
 };
 
-class TemplateURLServiceLoader : public content::NotificationObserver {
+class TemplateURLServiceLoader {
  public:
   explicit TemplateURLServiceLoader(TemplateURLService* model) : model_(model) {
-    registrar_.Add(this, chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED,
-                   content::Source<TemplateURLService>(model));
+    scoped_ptr<TemplateURLService::Subscription> subscription =
+        model_->RegisterOnLoadedCallback(
+            base::MessageLoop::current()->QuitClosure());
     model_->Load();
     content::RunMessageLoop();

[Avi (use Gerrit), 2013/10/02 22:27:52]

Er... This smells. Do you want MessageLoopRunner? Something like:

scoped_refptr<content::MessageLoopRunner> message_loop_runner = new
content::MessageLoopRunner;
scoped_ptr<TemplateURLService::Subscription> subscription =
        model_->RegisterOnLoadedCallback(
            message_loop_runner->QuitClosure());
model_->Load();
message_loop_runner->Run();

[Cait (Slow), 2013/10/03 15:36:45]

Done.

   }
 
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) {
-    if (type == chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED &&
-        content::Source<TemplateURLService>(source).ptr() == model_) {
-      base::MessageLoop::current()->Quit();
-    }
-  }
-
  private:
-  content::NotificationRegistrar registrar_;
-
   TemplateURLService* model_;
 
   DISALLOW_COPY_AND_ASSIGN(TemplateURLServiceLoader);
 };
 
 }  // namespace
 
 /*
 IN_PROC_BROWSER_TEST_F(TemplateURLScraperTest, ScrapeWithOnSubmit) {
   host_resolver()->AddRule("*.foo.com", "localhost");
@@ skipping 20 matching lines @@
       HTTPTestServer::CreateServerWithFileRootURL(
           L"chrome/test/data/template_url_scraper/submit_handler", L"/",
           g_browser_process->io_thread()->message_loop()));
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
       browser(), GURL("http://www.foo.com:1337/"), 2);
 
   all_urls = template_urls->GetTemplateURLs();
   EXPECT_EQ(1, all_urls.size() - prepopulate_urls.size());
 }
 */