Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/search_engines/template_url_service_android.cc

Issue 23710022: Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_android.cc
diff --git a/chrome/browser/search_engines/template_url_service_android.cc b/chrome/browser/search_engines/template_url_service_android.cc
index a84dd04b1317b80ba79d8ae9fc6040b2748bb0df..783725b9350a5bba0995d5bc1c760b5b6d3b1550 100644
--- a/chrome/browser/search_engines/template_url_service_android.cc
+++ b/chrome/browser/search_engines/template_url_service_android.cc
@@ -5,18 +5,16 @@
#include "chrome/browser/search_engines/template_url_service_android.h"
#include "base/android/jni_string.h"
+#include "base/bind.h"
#include "base/format_macros.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/search_engines/search_terms_data.h"
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_prepopulate_data.h"
-#include "chrome/browser/search_engines/template_url_service.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
-#include "content/public/browser/notification_source.h"
#include "jni/TemplateUrlService_jni.h"
using base::android::ConvertJavaStringToUTF16;
@@ -37,27 +35,15 @@ TemplateUrlServiceAndroid::TemplateUrlServiceAndroid(JNIEnv* env,
: weak_java_obj_(env, obj),
template_url_service_(
TemplateURLServiceFactory::GetForProfile(GetOriginalProfile())) {
- registrar_.Add(this,
- chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED,
- content::Source<TemplateURLService>(template_url_service_));
+ template_url_subscription_ =
+ template_url_service_->RegisterOnLoadedCallback(
+ base::Bind(&TemplateUrlServiceAndroid::OnTemplateURLServiceLoaded,
+ base::Unretained(this)));
}
TemplateUrlServiceAndroid::~TemplateUrlServiceAndroid() {
}
-void TemplateUrlServiceAndroid::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- DCHECK_EQ(chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED, type);
- JNIEnv* env = base::android::AttachCurrentThread();
- if (weak_java_obj_.get(env).is_null())
- return;
-
- Java_TemplateUrlService_templateUrlServiceLoaded(env,
- weak_java_obj_.get(env).obj());
-}
-
void TemplateUrlServiceAndroid::Load(JNIEnv* env, jobject obj) {
template_url_service_->Load();
}
@@ -140,6 +126,16 @@ bool TemplateUrlServiceAndroid::IsPrepopulatedTemplate(TemplateURL* url) {
return url->prepopulate_id() > 0;
}
+void TemplateUrlServiceAndroid::OnTemplateURLServiceLoaded() {
+ template_url_subscription_.reset();
+ JNIEnv* env = base::android::AttachCurrentThread();
+ if (weak_java_obj_.get(env).is_null())
+ return;
+
+ Java_TemplateUrlService_templateUrlServiceLoaded(
+ env, weak_java_obj_.get(env).obj());
+}
+
base::android::ScopedJavaLocalRef<jstring>
TemplateUrlServiceAndroid::GetUrlForSearchQuery(JNIEnv* env,
jobject obj,

Powered by Google App Engine
This is Rietveld 408576698