Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3619)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 23710022: Convert NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED to CallbackList (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index fd815cdbc2434d90a10e0a7ea33137ea932bbd77..41cc2e96acc6561d0d5c0280b6a7c9c271c65e01 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -4,7 +4,6 @@
#include <stdio.h>
-#include "base/message_loop/message_loop.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -262,13 +261,7 @@ class OmniboxViewTest : public InProcessBrowserTest,
TemplateURLServiceFactory::GetForProfile(profile);
ASSERT_TRUE(model);
- if (!model->loaded()) {
- content::NotificationRegistrar registrar;
- registrar.Add(this, chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED,
- content::Source<TemplateURLService>(model));
- model->Load();
- content::RunMessageLoop();
- }
+ ui_test_utils::WaitForTemplateURLServiceToLoad(model);
ASSERT_TRUE(model->loaded());
// Remove built-in template urls, like google.com, bing.com etc., as they
@@ -364,7 +357,6 @@ class OmniboxViewTest : public InProcessBrowserTest,
case chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY:
case chrome::NOTIFICATION_HISTORY_LOADED:
case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED:
- case chrome::NOTIFICATION_TEMPLATE_URL_SERVICE_LOADED:
break;
default:
FAIL() << "Unexpected notification type";
« no previous file with comments | « chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698