Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2366623002: services/ui: Initialize all of gpu in one thread. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 2 months ago
Reviewers:
rjkroege, sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Initialize all of gpu in one thread. The current code initializes GL, some of the gpu components (e.g. GpuMemoryBufferFactory) in one thread, and then uses them in the gpu thread. This is not correct, and causes some platforms to also crash. So, move all of GL/gpu initializations into the dedicated gpu thread. BUG=none Committed: https://crrev.com/5b860bd1502a646db283473be4d68d275d51a002 Cr-Commit-Position: refs/heads/master@{#420974}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -115 lines) Patch
M services/ui/gpu/gpu_main.h View 2 chunks +16 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 2 2 chunks +98 lines, -9 lines 4 comments Download
M services/ui/gpu/gpu_service_internal.h View 4 chunks +3 lines, -14 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 6 chunks +13 lines, -89 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (18 generated)
sadrul
There are several issues at play right now for the crashes on device. This fixes ...
4 years, 3 months ago (2016-09-23 17:28:46 UTC) #14
rjkroege
lgtm but I want to talk about threading and message pump types in mus-gpu at ...
4 years, 2 months ago (2016-09-25 14:31:21 UTC) #15
sadrul
+sky@ for ws change. https://codereview.chromium.org/2366623002/diff/40001/services/ui/gpu/gpu_main.cc File services/ui/gpu/gpu_main.cc (right): https://codereview.chromium.org/2366623002/diff/40001/services/ui/gpu/gpu_main.cc#newcode52 services/ui/gpu/gpu_main.cc:52: thread_options.message_loop_type = base::MessageLoop::TYPE_UI; On 2016/09/25 ...
4 years, 2 months ago (2016-09-25 22:09:58 UTC) #17
sky
LGTM - can you please add OWNERS for services/ui/ws and make you and Fady owners ...
4 years, 2 months ago (2016-09-26 16:05:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366623002/40001
4 years, 2 months ago (2016-09-26 16:33:53 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286274)
4 years, 2 months ago (2016-09-26 18:06:07 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366623002/40001
4 years, 2 months ago (2016-09-26 18:25:06 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-26 20:15:56 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 20:18:39 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b860bd1502a646db283473be4d68d275d51a002
Cr-Commit-Position: refs/heads/master@{#420974}

Powered by Google App Engine
This is Rietveld 408576698