Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2360203003: services/ui: Add mojom API for creating/destroying gpu memory buffer. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, sky, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Add mojom API for creating/destroying gpu memory buffer. Add struct-traits for gpu::SurfaceHandle, and use that to provide mojom API for creating/destroying gpu memory buffer. This allows removing the direct dependency of gpu code from ws code (which is a pre-requisite for the gpu process split). BUG=637923 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/763bd5900392427eff240119f238754c1e4923e1 Cr-Commit-Position: refs/heads/master@{#421201}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -30 lines) Patch
M components/display_compositor/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 2 3 4 5 6 7 4 chunks +15 lines, -0 lines 0 comments Download
A + gpu/ipc/common/surface_handle.mojom View 3 1 chunk +3 lines, -3 lines 0 comments Download
A gpu/ipc/common/surface_handle.typemap View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A gpu/ipc/common/surface_handle_struct_traits.h View 1 3 1 chunk +37 lines, -0 lines 0 comments Download
M gpu/ipc/common/typemaps.gni View 3 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 3 6 2 chunks +11 lines, -12 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 3 6 1 chunk +5 lines, -4 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service_internal.mojom View 3 2 chunks +15 lines, -0 lines 0 comments Download
M services/ui/ws/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/mus_gpu_memory_buffer_manager.h View 3 chunks +5 lines, -2 lines 0 comments Download
M services/ui/ws/mus_gpu_memory_buffer_manager.cc View 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 40 (33 generated)
sadrul
tsepez@ for the mojom changes and struct-traits piman@ for code in display_compositor and gpu, services/ui/gpu ...
4 years, 3 months ago (2016-09-24 01:56:40 UTC) #20
sky
LGTM
4 years, 2 months ago (2016-09-26 15:25:07 UTC) #23
piman
lgtm
4 years, 2 months ago (2016-09-26 18:22:15 UTC) #24
Tom Sepez
mojom/traits LGTM
4 years, 2 months ago (2016-09-26 19:11:14 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360203003/140001
4 years, 2 months ago (2016-09-27 14:28:59 UTC) #36
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 2 months ago (2016-09-27 14:34:04 UTC) #38
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:37:03 UTC) #40
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/763bd5900392427eff240119f238754c1e4923e1
Cr-Commit-Position: refs/heads/master@{#421201}

Powered by Google App Engine
This is Rietveld 408576698